| Summary: | games-sports/xmoto-0.5.11-r1: ISO C++ forbids comparison between pointer | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andrius Štikonas <andrius> |
| Component: | Current packages | Assignee: | Gentoo Games <games> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander, jstein, plevine457 |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853712 | ||
| See Also: |
https://github.com/gentoo/gentoo/pull/7288 https://github.com/gentoo/gentoo/pull/7604 |
||
| Whiteboard: | ~arch only | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 617524 | ||
| Attachments: | build.log.xz | ||
|
Description
Andrius Štikonas
2018-02-04 12:28:41 UTC
Created attachment 517772 [details]
build.log.xz
(In reply to Peter Levine from comment #2) > PR: https://github.com/gentoo/gentoo/pull/7604 Just noticed there is a PR outstanding. Sorry. Disregard. I'll merge if it works for you but whenever I start a level, the bike falls through the floor and the screen goes blank. :| Yes, the game works for me. Just tried several aeRo's Training levels. (In reply to James Le Cuirot from comment #4) > I'll merge if it works for you but whenever I start a level, the bike falls > through the floor and the screen goes blank. :| I'm getting the same problem. (In reply to Peter Levine from comment #3) > (In reply to Peter Levine from comment #2) > > PR: https://github.com/gentoo/gentoo/pull/7604 > > Just noticed there is a PR outstanding. Sorry. Disregard. (In reply to James Le Cuirot from comment #4) > I'll merge if it works for you but whenever I start a level, the bike falls > through the floor and the screen goes blank. :| I adjusted and reopened my PR. Debian entirely removes "${S}"/src/ode before building and this appears to be the correct behavior. Otherwise, xmoto seems to compile, build, and link extraneous, unbundled dev-games/ode code leading to the blank screen problem. With the removal of "${S}"/src/ode, there doesn't seem any need to include the -DdDOUBLE or -DdSINGLE flag referenced by https://bugs.gentoo.org/289792. There is a need to make sure that xmoto is rebuilt if the dev-games/ode is rebuilt with a change in its "double-precision" USE flag, otherwise xmoto will fail with a message like > fatal exception : XMoto compiled with ode as double precision, but libode library wasn't. So I added the "double-precision" USE flag to xmoto with the dependency of "dev-games/ode[double-precision=]". Thanks. I've closed my PR. (In reply to Peter Levine from comment #7) > So I added the "double-precision" USE flag to xmoto with the dependency of > "dev-games/ode[double-precision=]". This doesn't make sense because you're not actually using the flag anywhere except in the dependency, which implies that it doesn't matter. Perhaps unbundling ODE was enough? (In reply to James Le Cuirot from comment #9) > (In reply to Peter Levine from comment #7) > > So I added the "double-precision" USE flag to xmoto with the dependency of > > "dev-games/ode[double-precision=]". > > This doesn't make sense because you're not actually using the flag anywhere > except in the dependency, which implies that it doesn't matter. Perhaps > unbundling ODE was enough? True. It's used to force a rebuild of xmoto via `emerge -uDN @world` when the flag changes for ODE. If you want I can get rid of it. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d9f86160e7814a3ca4d124024c4bccd3d97f75b4 commit d9f86160e7814a3ca4d124024c4bccd3d97f75b4 Author: Peter Levine <plevine457@gmail.com> AuthorDate: 2018-03-27 03:37:49 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2018-03-27 21:45:14 +0000 games-sports/xmoto: Fix building with GCC-7 Bug: https://bugs.gentoo.org/646578 Package-Manager: Portage-2.3.16, Repoman-2.3.6 Closes: https://github.com/gentoo/gentoo/pull/7604 games-sports/xmoto/Manifest | 1 + games-sports/xmoto/metadata.xml | 1 + games-sports/xmoto/xmoto-0.5.11-r2.ebuild | 92 +++++++++++++++++++++++++++++++ 3 files changed, 94 insertions(+)} (In reply to Peter Levine from comment #10) > True. It's used to force a rebuild of xmoto via `emerge -uDN @world` when > the flag changes for ODE. If you want I can get rid of it. Ah yes, right you are. Merged! |
