| Summary: | net-misc/miniupnpd: QA issues with init.d file | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Current packages | Assignee: | Patrick McLean <chutzpah> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | chutzpah, mgorny |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 609070 | ||
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=558047cd7e9293f68003d0af7f411fc77d1ceed0 commit 558047cd7e9293f68003d0af7f411fc77d1ceed0 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2019-06-30 07:07:03 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2019-06-30 07:39:14 +0000 net-misc/miniupnpd: Fix bashisms in init.d file Closes: https://bugs.gentoo.org/646548 Signed-off-by: Michał Górny <mgorny@gentoo.org> net-misc/miniupnpd/files/miniupnpd-init.d-r2 | 33 +++++++++++ .../miniupnpd/miniupnpd-2.1.20190625-r1.ebuild | 65 ++++++++++++++++++++++ 2 files changed, 98 insertions(+) |
* Messages for package net-misc/miniupnpd-2.0.20180203: * Log file: /var/log/portage/net-misc:miniupnpd-2.0.20180203:20180204-081358.log * Please correct the external interface in the top of the two * scripts in /etc/miniupnpd and edit the config file in there too * QA Notice: shell script appears to use non-POSIX feature(s): * possible bashism in /etc/init.d/miniupnpd line 18 (alternative test command ([[ foo ]] should be [ foo ])): * if [[ -z ${no_iptables_scripts} ]]; then * possible bashism in /etc/init.d/miniupnpd line 28 (alternative test command ([[ foo ]] should be [ foo ])): * if [[ -z ${no_iptables_scripts} ]]; then