Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 646548 - net-misc/miniupnpd: QA issues with init.d file
Summary: net-misc/miniupnpd: QA issues with init.d file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 609070
  Show dependency tree
 
Reported: 2018-02-04 08:15 UTC by Michał Górny
Modified: 2019-06-30 07:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-02-04 08:15:58 UTC
* Messages for package net-misc/miniupnpd-2.0.20180203:
 * Log file: /var/log/portage/net-misc:miniupnpd-2.0.20180203:20180204-081358.log

 * Please correct the external interface in the top of the two
 * scripts in /etc/miniupnpd and edit the config file in there too
 * QA Notice: shell script appears to use non-POSIX feature(s):
 *    possible bashism in /etc/init.d/miniupnpd line 18 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	if [[ -z ${no_iptables_scripts} ]]; then
 *    possible bashism in /etc/init.d/miniupnpd line 28 (alternative test command ([[ foo ]] should be [ foo ])):
 *    	if [[ -z ${no_iptables_scripts} ]]; then
Comment 1 Larry the Git Cow gentoo-dev 2019-06-30 07:39:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=558047cd7e9293f68003d0af7f411fc77d1ceed0

commit 558047cd7e9293f68003d0af7f411fc77d1ceed0
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-06-30 07:07:03 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-06-30 07:39:14 +0000

    net-misc/miniupnpd: Fix bashisms in init.d file
    
    Closes: https://bugs.gentoo.org/646548
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 net-misc/miniupnpd/files/miniupnpd-init.d-r2       | 33 +++++++++++
 .../miniupnpd/miniupnpd-2.1.20190625-r1.ebuild     | 65 ++++++++++++++++++++++
 2 files changed, 98 insertions(+)