Summary: | dev-python/pypy{,3}-5.10.0: doins: Unknown install options: -p, ['-p'] | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Patrick Lauer <patrick> |
Component: | Core - Ebuild Support | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mgorny |
Priority: | Normal | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 645194 |
Description
Patrick Lauer
2017-12-29 12:45:21 UTC
Patch posted for review: https://archives.gentoo.org/gentoo-portage-dev/message/e4857ce149479c2660f267663bc80ef9 https://github.com/gentoo/portage/pull/240 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=d459f05ff71f8ccb8deea2d43c2992a8ae0b0d52 commit d459f05ff71f8ccb8deea2d43c2992a8ae0b0d52 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2017-12-29 20:15:37 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2018-01-08 05:47:48 +0000 bin/doins.py: implement install -p option (bug 642632) Bug: https://bugs.gentoo.org/642632 Reviewed-by: Alec Warner <antarus@gentoo.org> Reviewed-by: Mike Gilbert <floppym@gentoo.org> bin/doins.py | 34 +++++++++++++++++++++++++++++----- pym/portage/tests/bin/test_doins.py | 6 ++++-- 2 files changed, 33 insertions(+), 7 deletions(-)} With python2.7, it's not possible to preserve nanoseconds with complete precision, since precision is lost in conversion to/from float. It's not a problem in python3.3 and later since nanosecond precision is fully supported. So, I'm thinking that maybe we should just use 1 second precision under python2.7. Provided this wouldn't cause unequal values due to rounding, I suppose that would work. Otherwise, we should probably use C extension for it. (or just figure out that reinventing basic shell commands in Python is a stupid idea) I think it's acceptable to just fallback to the install command in order to avoid timestamp precision loss for python2, so I've sent this patch for review: https://archives.gentoo.org/gentoo-portage-dev/message/fc27b9058658da7305b40a6b25860ece https://github.com/gentoo/portage/pull/243 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=e81497dec819dbfc8e85e533db30d751fadaad81 commit e81497dec819dbfc8e85e533db30d751fadaad81 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2018-01-15 04:36:39 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2018-01-17 19:38:44 +0000 bin/doins.py: avoid timestamp precision loss with python2 (bug 642632) Since conversion to/from float results in timestamp precision loss with less than Python 3.3, do not use the python implementation in this case. Bug: https://bugs.gentoo.org/642632 Fixes: d459f05ff71f ("bin/doins.py: implement install -p option (bug 642632)") bin/doins.py | 4 ++++ 1 file changed, 4 insertions(+)} |