Bug 631796 – app-misc/recoll - clean up Qt handling

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Michael Palimaka (kensington) 2017-09-23 02:03:35 UTC]

Qt 4 is dead, so please consider removing that USE flag.

Also, using QT_SELECT is not recommended as that's an implementation detail of qtchooser and cannot be relied on. It's better to call the required qt binaries directly, either by passing some build system argument or patching the source (there's some helper functions in qmake-utils.eclass to get the right directory).

Let me know if you'd like a patch.

[Comment 1 P Purkayastha 2017-09-24 07:59:19 UTC]

Created attachment 496210 [details]
recoll-1.23.3.ebuild

Hi,

 I have updated the ebuild to

1. include recoll-1.23.3 that has been released.
2. remove qt4 from the ebuild.

 Do let me know if the changes to the ebuild suffice.

[Comment 2 Michael Palimaka (kensington) 2017-09-24 08:53:31 UTC]

Looks good, thanks!

[Comment 3 Larry the Git Cow 2017-09-24 08:53:46 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8025347c1c42763173c720bbb94d01204e6aa5d

commit e8025347c1c42763173c720bbb94d01204e6aa5d
Author:     Michael Palimaka <[e-mail]>
AuthorDate: 2017-09-24 08:53:20 +0000
Commit:     Michael Palimaka <[e-mail]>
CommitDate: 2017-09-24 08:53:36 +0000

    app-misc/recoll: version bump 1.23.3
    
    Closes: https://bugs.gentoo.org/631796
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 app-misc/recoll/Manifest             |   1 +
 app-misc/recoll/recoll-1.23.3.ebuild | 123 +++++++++++++++++++++++++++++++++++
 2 files changed, 124 insertions(+)

[Comment 4 Michael Palimaka (kensington) 2017-09-24 08:54:29 UTC]

Sorry, I forgot to update the author information before pushing the commit. My bad.