Summary: | app-admin/keepass can display a high resolution icon by capturing WMClass | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Brad Laue <brad> |
Component: | Current packages | Assignee: | Alessandro Di Federico <ale> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fearedbliss, jstein, kensington, proxy-maint |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
keepass-keepass.desktop with defined WM Class
GNOME screnshot GNOME screenshot with WMClass set |
Which desktop do you use? I'm curious to see the difference. Created attachment 488892 [details]
GNOME screnshot
Hi Michael,
I'm using GNOME 3.22 and Plasma desktops currently on various machines - I'm at a GNOME system now so I've attached a screenshot.
Brad
Created attachment 488894 [details]
GNOME screenshot with WMClass set
And one of the fixed desktop file. Considerably nicer!
Alessandro, you're the maintainer of this package. Have you reviewed this patch? Sorry for the delay, it works for me. I see green leaf icon if I enabled it, but its higher res. It can go in. The patch is not applicable as-is and needs ebuild work. Maybe think about including it in your next version bump Alessandro. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9c5bb37bf6ebebec1b9990ee9294ada0cd250ce6 commit 9c5bb37bf6ebebec1b9990ee9294ada0cd250ce6 Author: Michael Palimaka <kensington@gentoo.org> AuthorDate: 2018-10-06 10:31:54 +0000 Commit: Michael Palimaka <kensington@gentoo.org> CommitDate: 2018-10-06 10:32:26 +0000 app-admin/keepass: define WMClass in .desktop file Closes: https://bugs.gentoo.org/626710 Signed-off-by: Michael Palimaka <kensington@gentoo.org> Package-Manager: Portage-2.3.49, Repoman-2.3.11 app-admin/keepass/keepass-2.40-r1.ebuild | 111 +++++++++++++++++++++++++++++++ 1 file changed, 111 insertions(+) |
Created attachment 487432 [details, diff] keepass-keepass.desktop with defined WM Class Setting StartupWMClass in the XDG desktop file (/usr/share/applications/keepass-keepass.desktop) for app-admin/keepass will display the proper high resolution icon for it. Currently a low-res icon is displayed in hidpi environments. The attached diff shows the needed addition.