Summary: | media-sound/easytag-2.4.3 corrupts Ogg, Opus, needs warning / masking | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Florian Berger <florian.berger> |
Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | arcctgx |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Prevent corruption of Ogg container |
Description
Florian Berger
2017-05-08 08:26:54 UTC
It appears the commit that causes corruption is known and that OpenSuSE fixes it with a patch that undoes the commit: https://build.opensuse.org/request/show/596947 Attaching the patch for this in a few seconds; ideally it should be part of a revised ebuild. Created attachment 556456 [details, diff]
Prevent corruption of Ogg container
I'm surprised to see this is still "Unconfirmed" after more than a year. The root cause was identified in the discussion at EasyTAG's Bugzilla [1]. I'm having exactly the same issue with easytag-2.4.3 in Gentoo, and I can confirm that the attached patch which reverts the offending upstream commit e5c640ca3f fixes this. I tested by first modifying an Ogg Vorbis file with patched EasyTAG. Then I ran ogginfo on the modified file and saw no "Negative or zero granulepos" errors. Finally, I used my hardware player to play this modified file, and it was successful (previously it was crashing when I attempted to play a file corrupted by EasyTAG). Please consider patching this in Gentoo. It is important because the upstream development has stalled, and we're stuck with a buggy version now. [1] https://bugzilla.gnome.org/show_bug.cgi?id=776110 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=645351f868ac449b80ad507dd46ad0ccb1c3874e commit 645351f868ac449b80ad507dd46ad0ccb1c3874e Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-12-02 17:41:23 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-12-02 18:43:35 +0000 media-sound/easytag: Fix ogg corruption Non-maintainer commit. (Revert) Patch taken from openSUSE. See also: https://bugzilla.gnome.org/show_bug.cgi?id=776110 Reported-by: Florian Berger <florian.berger@posteo.de> Thanks-to: Patrice Levesque <gentoo.wayne@ptaff.ca> Closes: https://bugs.gentoo.org/617818 Package-Manager: Portage-2.3.52, Repoman-2.3.12 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> media-sound/easytag/easytag-2.4.3-r1.ebuild | 72 ++++++ .../files/easytag-2.4.3-ogg-corruption.patch | 246 +++++++++++++++++++++ 2 files changed, 318 insertions(+) |