Summary: | =app-misc/gcstar-1.7.1 version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Giuseppe Foti <foti.giuseppe> |
Component: | Current packages | Assignee: | Alexandre Rostovtsev (RETIRED) <tetromino> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, timeraider |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
just worked on my system, no more test done
app-misc/gcstar-1.7.1.ebuild |
Description
Giuseppe Foti
2017-01-22 08:54:43 UTC
thank you for your contribution. I had a short look ad the ebuild. Here my suggestions: * always try to use the most recent EAPI. * There is a "ebuild-checker" which can show several common mistakes in ebuilds. You start it with repoman -d full * remove some of the empty lines obsolete code like # epatch "${FILESDIR}/${P}-gcstar.desktop.patch" * A for loop like for size in 16 22 24 32 36 48 64 72 96 128 256 do insinto /usr/share/icons/hicolor/${size}x${size}/apps newins share/gcstar/icons/gcstar_${size}x${size}.png gcstar.png done is often used, but as far I know it is superseded by doicon and newicon https://devmanual.gentoo.org/eclass-reference/eutils.eclass/ Created attachment 466892 [details]
app-misc/gcstar-1.7.1.ebuild
Dear all, I have attached an updated version of the ebuild, based on the contribution by Giuseppe. @Alexandre did you already review the ebuild? Do you still have the time to maintain this package? Fixed; thanks to Giuseppe, Jonas, and Harald for the ebuild and comments. I apologize for the unacceptably long delay in addressing this. commit 687e0c4fb428289dca2ea45f1459025da242bea6 Author: Alexandre Rostovtsev <tetromino@gentoo.org> Date: Fri Mar 23 17:21:43 2018 -0400 app-misc/gcstar: belated version bump to 1.7.1 - bug #606784 |