Summary: | repoman should warn when virtual/ffmpeg is pulled as dependency | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Pacho Ramos <pacho> |
Component: | Repoman | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | itumaykin+gentoo, media-video |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/17678 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Pacho Ramos
2017-01-16 12:30:27 UTC
(In reply to Pacho Ramos from comment #0) Why? virtual/ffmpeg is for ffmpeg/avconv executable, when no linking happens. Such cases exist. From virtual/ffmpeg ebuild: # Please note that this virtual is only suited for packages that call # ffmpeg/avconv or one of the remaining executables. If your package # links to one of the libraries, you need to use the following # dependency instead (adding IUSE=libav): # libav? ( media-video/libav:0= ) # !libav? ( media-video/ffmpeg:0= ) Packages with virtual/ffmpeg in RDEPEND only are probably fine. Packages that have virtual/ffmpeg in DEPEND are suspect: linking against ffmpeg libs is wrong, but calling the binaries is ok. I would say that comment in virtual/ffmpeg is also outdated given that media-video/libav and avconv are abandoned upstream and gone from Portage half year ago. Also, shouldn't this discussion happen in #744787 instead? Sorry, I just noticed I was replying to old comments written when what I said was still not true. I though these were new comments to #744784. Both tickets are related though. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2faf7d23d98512885ca32bb0fd81c63fb8220e24 commit 2faf7d23d98512885ca32bb0fd81c63fb8220e24 Author: Jesus P Rey (Chuso) <gentoo@chuso.net> AuthorDate: 2020-09-26 12:52:40 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2020-09-26 15:59:38 +0000 profiles: deprecate virtual/ffmpeg in favour of only provider Signed-off-by: Jesus P Rey <gentoo@chuso.net> Bug: https://bugs.gentoo.org/744787 Closes: https://bugs.gentoo.org/605882 Closes: https://github.com/gentoo/gentoo/pull/17678 Signed-off-by: Zac Medico <zmedico@gentoo.org> profiles/package.deprecated | 5 +++++ 1 file changed, 5 insertions(+) |