| Summary: | app-vim/gentoo-syntax - improve initd skel | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sergey S. Starikoff <Ikonta> |
| Component: | Current packages | Assignee: | Vim Maintainers <vim> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | bkohler, mgorny, yngwin |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo-syntax/pull/21 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
I don't understand what's obsolete about this, can you explain? A skel file isn't supposed to be a detailed example. (In reply to Ben Kohler from comment #1) > I don't understand what's obsolete about this, can you explain? A skel file > isn't supposed to be a detailed example. Skel file isn't supposed to be a detailed example, but as for me, it is supposed to be up to date and corresponds with some minimal-typical example. For recent versions of OpenRC it means, that the only probably needed section is depend. But we need to declare some variables. Header of example in man 8 openrc-run (possibly with empty values) looks sufficiently: #!/sbin/openrc-run # Copyright 1999-2017 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Id$ command=/usr/bin/foo command_args="${foo_args} --bar" pidfile=/var/run/foo.pid name="FooBar Daemon" description="FooBar is a daemon that eats and drinks" depend() { } Please see/test the linked PR. I didn't include pidfile= since I'm not sure if it's really needed and if it's not, people will keep adding it unnecessarily. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/gentoo-syntax.git/commit/?id=8cbe8adba2433766276be8e8a09a827fce811aa9 commit 8cbe8adba2433766276be8e8a09a827fce811aa9 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2018-08-20 15:54:44 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-08-20 20:47:04 +0000 newinitd: Update for the modern declarative syntax Bug: https://bugs.gentoo.org/605078 plugin/newinitd.vim | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=daddf63e4386056e4f71945f9d5ed3247ac1e6e6 commit daddf63e4386056e4f71945f9d5ed3247ac1e6e6 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2018-08-20 20:50:21 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-08-20 21:06:43 +0000 app-vim/gentoo-syntax: Bump to 20180820 Closes: https://bugs.gentoo.org/637104 Closes: https://bugs.gentoo.org/637100 Closes: https://bugs.gentoo.org/605078 app-vim/gentoo-syntax/Manifest | 1 + .../gentoo-syntax/gentoo-syntax-20180820.ebuild | 42 ++++++++++++++++++++++ 2 files changed, 43 insertions(+) |
Creating in my favourite text editor vim some new initd file for openrc I see the following skel: #!/sbin/openrc-run # Copyright 1999-2017 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Id$ depend() { } start() { } stop() { } It looks obsolete. I expect to see on it's place something corresponding with exmple in man 8 openrc-run, possibly not so detailed. $ einfo Portage 2.3.0 (python 3.4.5-final-0, default/linux/amd64/13.0, gcc-4.9.4, glibc-2.23-r3, 4.4.39-gentoo x86_64) ================================================================= System uname: Linux-4.4.39-gentoo-x86_64-Intel-R-_Core-TM-_i5_CPU_661_@_3.33GHz-with-gentoo-2.3 KiB Mem: 7976172 total, 5200780 free KiB Swap: 4024240 total, 4024240 free Timestamp of repository gentoo: Fri, 06 Jan 2017 10:15:01 +0000 sh bash 4.3_p48-r1 ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1 app-shells/bash: 4.3_p48-r1::gentoo dev-java/java-config: 2.2.0-r3::gentoo dev-lang/perl: 5.22.3_rc4::gentoo dev-lang/python: 2.7.12::gentoo, 3.4.5::gentoo dev-util/cmake: 3.6.3::gentoo dev-util/pkgconfig: 0.28-r2::gentoo sys-apps/baselayout: 2.3::gentoo sys-apps/openrc: 0.22.4::gentoo sys-apps/sandbox: 2.10-r1::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69::gentoo sys-devel/automake: 1.11.6-r1::gentoo, 1.14.1::gentoo, 1.15::gentoo sys-devel/binutils: 2.25.1-r1::gentoo sys-devel/gcc: 4.9.4::gentoo sys-devel/gcc-config: 1.7.3::gentoo sys-devel/libtool: 2.4.6-r2::gentoo sys-devel/make: 4.1-r1::gentoo sys-kernel/linux-headers: 4.4::gentoo (virtual/os-headers) sys-libs/glibc: 2.23-r3::gentoo Repositories: gentoo location: /usr/portage/gentoo sync-type: rsync sync-uri: rsync://mirror.yandex.ru/gentoo-portage/ priority: -1000 local location: /usr/portage/local masters: gentoo rion location: /usr/portage/layman/rion masters: gentoo priority: 0 ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="* -@EULA GPL*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /etc/conf.d/clock /etc/rc.conf /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/usr/portage/distfiles/" EMERGE_DEFAULT_OPTS="--ask=y --verbose --autounmask=n" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs buildsyspkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="ftp://xeon.gentoo.ru/mirrors/gentoo/distfiles/ ftp://mirror2.corbina.ru/gentoo-distfiles/ http://mirror2.corbina.ru/gentoo-distfiles/ http://mirror.yandex.ru/gentoo-distfiles/ ftp://mirror.yandex.ru/gentoo-distfiles/ http://gentoo.bloodhost.ru/ ftp://gentoo.bloodhost.ru/ distfiles.gentoo.org" LANG="ru_RU.UTF8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages/" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X a52 acl alsa amd64 berkdb bzip2 cairo cdr cli consolekit cracklib crypt cups cxx dbus djvu dri dv dvd ffmpeg flac fortran gdbm gif gtk iconv icu jpeg jpeg2k kpathsea mac mmx mmxext modules mp3 mpeg multilib ncurses nls nptl ogg openmp pam pcre pdf png policykit qt3support readline seccomp session sse sse2 ssl tcpd tiff truetype unicode utf8 v4l v4l2 vorbis x264 xattr zlib" ABI_X86="64" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" L10N="ru" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="ru" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" QEMU_SOFTMMU_TARGETS="i386" QEMU_USER_TARGETS="i386" RUBY_TARGETS="ruby21" SANE_BACKENDS="genesys" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON