Summary: | mail-client/balsa-2.5.3 version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jack <ostroffjh> |
Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch for ebuild against current version
proposed ebuild Patch to configure.ac to allow balsa to work with >=gpgme-1.8 |
Description
Jack
2016-12-12 00:58:23 UTC
Created attachment 455956 [details, diff]
patch for ebuild against current version
Created attachment 455958 [details]
proposed ebuild
Created attachment 456342 [details, diff]
Patch to configure.ac to allow balsa to work with >=gpgme-1.8
gpgme-1.8 is thread-safe, so it no longer includes a gpgme-pthreads so file. The patch (from upstream balsa, pulled from a git commit) allows balsa to do the right thing if gpgme is 1.8 or above. Note this also requires an epatch line added to the ebuild. I'll be glad to update the ebuild and patch, if desired.
I'm not sure why we (gnome@) still maintain this. Looks like it was a historical thing ever since 2002-2004 that gnome@ maintained. Nowadays we have plenty already with evolution. Would you (Jack) consider proxy maintaining it completely together with gentoo proxy maintainers project instead for the long term, or does anyone in GNOME team have continued interest in this? It's still nominally a gnome project, although admittedly not a core part of gnome. I will proxy maintain to avoid maintainer needed, but I'll certainly need help with proper ebuilds. One new thing about this ebuild - for this release, the gtk3 branch has become master, so the gtk depends needs to change. I'll try to do that in the next days (too much real life this weekend.) (In reply to Jack from comment #3) > Created attachment 456342 [details, diff] [details, diff] > Patch to configure.ac to allow balsa to work with >=gpgme-1.8 > > gpgme-1.8 is thread-safe, so it no longer includes a gpgme-pthreads so file. > The patch (from upstream balsa, pulled from a git commit) allows balsa to do > the right thing if gpgme is 1.8 or above. Note this also requires an epatch > line added to the ebuild. I'll be glad to update the ebuild and patch, if > desired. Do you have the references for this? I see this is not being applied in other distros even running that gpgme version Thanks I haven't been able to find a definitive reference yet, but this change was also made for KMyMoney. The problem will start to be seen in more applications, as gpgme-1.8, being thread safe, doesn't require the use of gpgmepp (or some variant) so an old build system would fail looking for an unneeded gpgmepp. (I think there was also another failure indicative of the same thing, but my memory is failing to dredge up the details.) https://git.reviewboard.kde.org/r/129371/#review100789 is where it was done for KMyMoney, but that actually originated for a slightly different issue, so I'm not sure how obvious it is for this problem. However, this review request was opened by ASturm (Gentoo KDE developer) so perhaps he can point to the appropriate justification. If there is still a question about the gpg stuff, I'd rather drop that patch and deal with it later as a revision or patch release, just so this version gets released before a new version comes out. personally I would try to get the patch upstreamed... as it seems it was coming from there... can't we simply wait for the next balsa version? Or is it broken on a hard way? (it seems other distributions are not needing to patch it just now even running with newer gpgme versions) I got that patch from them. It's already in their git master. I just don't know how soon they will make another release. I'd rather go with the current release without that patch than to wait. I've already forgotten the details - but I don't think balsa will fail with gpgme-1.8, as long as it can also find the thread-safe call it used previously (from a vague memory, something like libpthread, but I'm really not sure.) Although I'm currently running Balsa compiled from git, it looks like I see 2.5.3 in portage. If I'm not seeing things, does that mean this request can be closed? |