Summary: | sys-block/open-iscsi-[2.0.873-r2, 2.0.874] should not insist upon "re-set to defaults" | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Manfred Knick <Manfred.Knick> |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | emerge --info sys-block/open-iscsi > 0_open-iscsi_emerge-info.txt |
Description
Manfred Knick
2016-12-03 13:02:29 UTC
yes, I assign the bug, but please add emerge --info and the .log in the meantime. Created attachment 455056 [details]
emerge --info sys-block/open-iscsi > 0_open-iscsi_emerge-info.txt
(In reply to Jonas Stein from comment #1) > yes, I assign the bug, Thanks, Jonas! > but please add emerge --info Done. > and _the_ .log <--- ? Build && Install both run successfully --> no ".log" in /var/log/portage/ > in the meantime. Kind regards It's now sys-block/open-iscsi-2.0.874 inb between. sys-block/open-iscsi/open-iscsi-2.0.874.ebuild, function src_install(), lines 94 / 95: insinto /etc/iscsi newins "${FILESDIR}"/initiatorname.iscsi initiatorname.iscsi.example .........................^^^^^^^^^^^^^^^^^^^ installs _un_conditionally, without checking if a (custom adjusted) version already exists. Hmm, at some point, upstream decided to ship their own /etc/iscsi/initiatorname.iscsi, but the ebuild was never properly updated for that. Fixed now in 2.0.874-r1. [master 909dc831cc0] sys-block/open-iscsi: prevent endless changes of /etc/iscsi/initiatorname.iscsi. Date: Sat Jun 17 20:28:05 2017 -0700 1 file changed, 121 insertions(+) create mode 100644 sys-block/open-iscsi/open-iscsi-2.0.874-r1.ebuild HINT: Even IF upstream WERE deterministic: According to RFC 3720, any project setup is free to choose its iSCSI Qualified Names (IQN) along literal iqn date authority Optional ":" prefixing a storage target name which must not be overwritten at (even minor) release updates. Thanks for applying your change! Concerning HOMEPAGE="https://github.com/open-iscsi/open-iscsi" # http://www.open-iscsi.com is dead <----- please note . . . [ http://scst.sourceforge.net ] PROPOSAL: HOMEPAGE="http://scst.sourceforge.net" "https://github.com/open-iscsi/open-iscsi" (In reply to Manfred Knick from comment #6) > Concerning > > HOMEPAGE="https://github.com/open-iscsi/open-iscsi" > # http://www.open-iscsi.com is dead <----- scst != open-iscsi. If you look at the GitHub page, it doesn't mention SCST at all. (In reply to Robin Johnson from comment #7) > (In reply to Manfred Knick from comment #6) > scst != open-iscsi. You are perfectly right - I apologize mixing things up (too many roads under simultaneous consideration). Correcting myself: --> http://www.open-iscsi.com/ points to https://github.com/open-iscsi/ points to https://github.com/open-iscsi/open-iscsi finally. Intended PROPOSAL: HOMEPAGE="http://www.open-iscsi.com" "https://github.com/open-iscsi/open-iscsi" so a novice gets pointed to the "Introduction" first. -- "Replace open-iscsi.org with open-iscsi.com" [ https://github.com/open-iscsi/open-iscsi/ commit/888ee69f17ad0faaee90aafcca25ec8942e9d293 ] Cross-Reference: Bug 575268 - sys-block/open-iscsi: "update HOMEPAGE/SRC_URI to github" https://bugs.gentoo.org/show_bug.cgi?id=575268#c4 |