Summary: | sys-apps/accountsservice: Add elogind support | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sven Eden <sven.eden> |
Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | asturm, kensington, sven.eden |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://bugs.freedesktop.org/show_bug.cgi?id=101251 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 620976 | ||
Bug Blocks: | 599470 | ||
Attachments: |
accountsservice-0.6.42-r4.ebuild
Patch to enable elogind support accountsservice-0.6.43-r1.ebuild Updated patch to enable elogind support accountsservice-0.6.43.ebuild.diff Updated Patch to enable elogind support Updated Patch to enable elogind support - configure.ac only accountsservice-0.6.43.ebuild.diff |
Description
Sven Eden
2016-11-11 15:54:12 UTC
Created attachment 453014 [details]
accountsservice-0.6.42-r4.ebuild
Updated ebuild that accepts sys-auth/elogind and adds a USE flag "elogind".
The support is patched in, the patch follows.
Created attachment 453016 [details, diff]
Patch to enable elogind support
This patch changes the following:
a) Add "--enable-elogind" to configure.ac
b) Make src/libaccountsservice/act-user-manager.c include <elogind/sd-login.h> if --enable-elogind was set.
Created attachment 455244 [details]
accountsservice-0.6.43-r1.ebuild
Version bump with elogind support.
As the previous version is based on the stable 0.6.42 version, I'll keep it in my overlay.
Created attachment 459788 [details, diff]
Updated patch to enable elogind support
This patch does enable elogind in a bit cleaner way.
It is a bit unfortunate but I guess it won't do without patching. I've used a symlink to /usr/include/systemd in my local overlay elogind copy to avoid touching code, but that does not avoid the buildsystem part. Have you already tried to submit it upstream? Created attachment 474504 [details, diff]
accountsservice-0.6.43.ebuild.diff
unconditionally patch elogind support
(In reply to Andreas Sturmlechner from comment #5) > Have you already tried to submit it upstream? Any updates on this? Instead of adding src_prepare, set GNOME2_EAUTORECONF="yes" after EAPI, before inherit. Reluctant to ACK it without upstream See Also bug at the very least. I just realized that I forgot to post my patch upstream. How embarrassing! Well, here it is: https://bugs.freedesktop.org/show_bug.cgi?id=101251 Created attachment 474904 [details, diff]
Updated Patch to enable elogind support
I have made the configure.ac part a bit clearer, and the source part a bit cleaner. Applies nicely, so far.
Created attachment 475330 [details, diff]
Updated Patch to enable elogind support - configure.ac only
This is an updated patch, that no longer needs to change any source files, like requested by upstream.
For this patch to be useful, elogind-229.4 must be used as the minimal version.
So the line
elogind? ( sys-auth/elogind )
must be changed into
elogind? ( >=sys-auth/elogind-229.4 )
in the ebuild.
Patch accepted by upstream with minor changes: https://cgit.freedesktop.org/accountsservice/commit/?id=9fdd1d95ec094a0df6d8d3dd9c8f04fa8499b845 So until the new version gets released, we can do with patching against >=sys-auth/elogind-229.4 it seems. Very nicely done - thanks! Created attachment 475420 [details, diff]
accountsservice-0.6.43.ebuild.diff
|