Bug 599346

Summary:	dev-util/electron-0.37.8 fails to build against >=dev-libs/icu-58.1
Product:	Gentoo Linux	Reporter:	Michael Reithinger <mreithinger>
Component:	Current packages	Assignee:	Elvis Pranskevichus <elvis>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ave, brad, cyshei, gentoo, jrmalaq, jstein, proxy-maint
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	594494
Attachments:	emerge --info '=dev-util/electron-0.37.8::gentoo' emerge -pqv '=dev-util/electron-0.37.8::gentoo' build log Patch adapted from chromium

Description Michael Reithinger 2016-11-09 21:57:17 UTC

Created attachment 452838 [details]
emerge --info '=dev-util/electron-0.37.8::gentoo'

The same patch as in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c72212dd should do it.

Comment 1 Michael Reithinger 2016-11-09 21:58:20 UTC

Created attachment 452840 [details]
emerge -pqv '=dev-util/electron-0.37.8::gentoo'

Comment 2 Michael Reithinger 2016-11-09 22:02:05 UTC

Created attachment 452842 [details]
build log

Comment 3 Brad Laue 2016-11-11 23:52:14 UTC

Created attachment 453074 [details, diff]
Patch adapted from chromium

The patch for chromium fails to directly apply, probably version differences. I trimmed it to the following, which allows electron to build successfully.

Comment 4 Elvis Pranskevichus 2016-11-18 23:58:06 UTC

Fixed in https://github.com/gentoo/gentoo/pull/2835