| Summary: | [Patch] Add epatch check to repoman | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Danny van Dyk (RETIRED) <kugelfang> |
| Component: | Repoman | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 60345 | ||
| Attachments: | Patch for repoman to check epatch lines | ||
|
Description
Danny van Dyk (RETIRED)
2004-08-09 14:56:53 UTC
err... kugelfang? Created attachment 37123 [details, diff]
Patch for repoman to check epatch lines
[Sorry, the keyboard has fallen down :-/, here goes the real "bug"]
Anyway: I already talked w/ jstubbs about this patch, it allows repoman to
check
all occurences of epatch in an ebuild. If it detects env. variables in the
argument to epatch, it resolves them. (not all, up to now only FILESDIR, P,
PV,
PN) If the patchfile is not found in at its place, repoman fails with
"epatch.missing". If there are variables in epatch which are unknown to
repoman, it still raises a warning (epatch.unknown).
I'd really like to have this function in portage, as ppl who do version bumps
sometimes just overlook arch dependent epatch lines :-/ This shouldn't happen
anymore with this patch in repoman.
Brian: was an accident, i just had opened the form, and the keyboard fell down. Shit happens ;-) Seems this patch needs some loving. (BUG #60345) For example the line in comment #11 would be nice to be recognized. Brian: do you have any idea how to accomplish that ? Whatever happened with this check... and anyone up for trying to get it going again? Personally I think this is kinda messy, although most of epatch's are standard vars (FILESDIR, P,PV), I would hope that the arch teams/AT's will find crap like this before it hits the stable tree. Too many false positives to be usable. Reopen in case you have a better version. |
