| Summary: | games-emulation/dolphin-9999 - missing: Externals/glslang, Externals/hidapi | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Tear♪ <marach5> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jstein, sdavid.b, slyfox |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
dolphin-9999.ebuild patch
dolphin-9999.ebuild patch, with wxwidgets |
||
|
Description
Tear♪
2016-10-31 14:16:09 UTC
I just found that dolphin also provides the Vulkan headers in Externals, so the first dependency is fixed by also allowing the Externals/Vulkan directory. With the attached patch the build succeeds, but the built app obviously fails when trying to use the Vulkan backend, and it would be cleaner to use system headers which *should* be there in latest mesa as they're there in the source tree, but the Gentoo ebuild just opts out of Vulkan for now. I guess there's two separate bugs here, the build failure and the runtime failure, and Vulkan support ( https://bugs.gentoo.org/show_bug.cgi?id=574886 ) only blocks the second one. Created attachment 451981 [details, diff]
dolphin-9999.ebuild patch
Ugh... Opted in to wxwidgets UI, turns out that Dolphin now decides to use the bundled one anyway because the latest stable version in Gentoo is too old, and the latest upstream is supposedly broken: <degasus> Tear: have fun with no externals. eg right now, our WX GUI is broken on stable wxgtk Adding Externals/wxWidgets3 to the whitelist in the latest patch. Created attachment 452019 [details, diff]
dolphin-9999.ebuild patch, with wxwidgets
Thank you for the patch. The build is failing due to wxWidgets-3.1.0 not being on the tree. Your patch is preventing the bundled wxWidgets from being deleted. While it's not bad, I think this particular change shouldn't be allowed in the tree. If you want to apply your patch, feel free to keep it on an overlay until this is resolved. I'll keep the bug in case anyone wants to make use of this or until the ebuild for 3.1.0 is in the tree. Since dolphin-9999 doesn't build right now due to upstream changes unless we allow it to bring in multiple externals, I think it would make sense to allow the ones in that do not exist in the portage tree to remain in the build directory, and for those that do exist, add depends into the ebuild. What's the rationale for insisting on removal of wxwidgets-3.1.0 (essential for the build) but not the other four that we're preserving? The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7bb6ef82a48532432ec66af39d50df7cff3237ff commit 7bb6ef82a48532432ec66af39d50df7cff3237ff Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2018-07-22 12:27:16 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2018-07-22 12:27:25 +0000 games-emulation/dolphin: adopt an orphan, refresh live ebuild A few minor changes: - refreshed locale list (as suggested by the ebuild check) - moved from EAPI=5 to EAPI=6 - dropped removed WxWidgets UI - added depends on more bundled libraries Closes: https://bugs.gentoo.org/561914 Closes: https://bugs.gentoo.org/598625 Closes: https://bugs.gentoo.org/632882 Package-Manager: Portage-2.3.43, Repoman-2.3.10 games-emulation/dolphin/dolphin-9999.ebuild | 90 ++++++++++++++++------------- games-emulation/dolphin/metadata.xml | 5 +- 2 files changed, 54 insertions(+), 41 deletions(-) *** Bug 638632 has been marked as a duplicate of this bug. *** |
