Summary: | media-video/vlc: backport alsa patches from Debian | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Emmanuel Lepage Vallee <elv1313> |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | asturm, herrtimson, joakim.tjernlund |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://trac.videolan.org/vlc/ticket/10422 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=629294 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Emmanuel Lepage Vallee
2016-09-17 20:40:49 UTC
What version of media-video/vlc do you have to patch? 2.2.4? > What version of media-video/vlc do you have to patch? 2.2.4?
Yes please, and all newer versions until this is fixed. I tried the patches, they work.
Same here, I need those patches for vlc 2.2.4 on ALSA Patches were added to vlc-2.2.9999 ebuild, so should be part of the next version bump as well. Thanks, fixed in 2.2.4-r1 (commit 7e29d89c6ffa1ba14c1364c1dc92dcc2f7b9e262). At least alsa-large-buffers.patch breaks vlc for other users, so this will need to be reverted. Looking at vlc-2.2.4-decoder-lock-scope.patch there is something odd there: static void DecoderDecodeAudio( decoder_t *p_dec, block_t *p_block ) @@ -1961,11 +1966,10 @@ /* Parameters changed, restart the aout */ vlc_mutex_lock( &p_owner->lock ); - - aout_DecDelete( p_owner->p_aout ); p_owner->p_aout = NULL; - vlc_mutex_unlock( &p_owner->lock ); + aout_DecDelete( p_owner->p_aout ); + input_resource_PutAout( p_owner->p_resource, p_aout ); } This moves aout_DecDelete( p_owner->p_aout ) to AFTER p_owner->p_aout = NULL; and that just doesn't make sense to me. I would test reverting the above part and see what happens. Well spotted! Removing that hunk solves bug 629294. 2.2.6-r2 added in git commit eff19da8e22050be19180b57c3df1984db7bd23f (In reply to Andreas Sturmlechner from comment #8) > Well spotted! Removing that hunk solves bug 629294. Nice, I will rebuild VLC now then :) |