Bug 594126 – media-video/vlc: backport alsa patches from Debian

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Emmanuel Lepage Vallee 2016-09-17 20:40:49 UTC]

Hello, VLC doesn't play at 1080p on my system unless those patches are added to the ebuild

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=734100#84

[Comment 1 Marek Szuba 2016-09-22 07:47:16 UTC]

What version of media-video/vlc do you have to patch? 2.2.4?

[Comment 2 Emmanuel Lepage Vallee 2016-09-22 08:17:32 UTC]

> What version of media-video/vlc do you have to patch? 2.2.4?

Yes please, and all newer versions until this is fixed. I tried the patches, they work.

[Comment 3 Joakim Tjernlund 2016-10-03 21:34:46 UTC]

Same here, I need those patches for vlc 2.2.4 on ALSA

[Comment 4 Andreas Sturmlechner 2016-11-26 18:04:10 UTC]

Patches were added to vlc-2.2.9999 ebuild, so should be part of the next version bump as well.

[Comment 5 Andreas Sturmlechner 2016-12-21 18:39:57 UTC]

Thanks, fixed in 2.2.4-r1 (commit 7e29d89c6ffa1ba14c1364c1dc92dcc2f7b9e262).

[Comment 6 Andreas Sturmlechner 2017-08-29 15:38:30 UTC]

At least alsa-large-buffers.patch breaks vlc for other users, so this will need to be reverted.

[Comment 7 Joakim Tjernlund 2017-08-29 18:38:07 UTC]

Looking at vlc-2.2.4-decoder-lock-scope.patch there is something odd there:
static void DecoderDecodeAudio( decoder_t *p_dec, block_t *p_block )
@@ -1961,11 +1966,10 @@
 
         /* Parameters changed, restart the aout */
         vlc_mutex_lock( &p_owner->lock );
-
-        aout_DecDelete( p_owner->p_aout );
         p_owner->p_aout = NULL;
-
         vlc_mutex_unlock( &p_owner->lock );
+        aout_DecDelete( p_owner->p_aout );
+
         input_resource_PutAout( p_owner->p_resource, p_aout );
     }

This moves aout_DecDelete( p_owner->p_aout ) to AFTER p_owner->p_aout = NULL;
and that just doesn't make sense to me.
I would test reverting the above part and see what happens.

[Comment 8 Andreas Sturmlechner 2017-08-29 19:10:11 UTC]

Well spotted! Removing that hunk solves bug 629294.

[Comment 9 Andreas Sturmlechner 2017-08-29 19:42:55 UTC]

2.2.6-r2 added in git commit eff19da8e22050be19180b57c3df1984db7bd23f

[Comment 10 Joakim Tjernlund 2017-08-29 20:07:47 UTC]

(In reply to Andreas Sturmlechner from comment #8)
> Well spotted! Removing that hunk solves bug 629294.

Nice, I will rebuild VLC now then :)