Summary: | www-client/chromium-54.0.2840.16 - ../../tools/gn/last_commit_position.py: AttributeError: 'NoneType' object has no attribute 'stdout' | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | klaus818 |
Component: | New packages | Assignee: | Chromium Project <chromium> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | akinzler |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
build log patch for unneeded "git log" call |
Description
klaus818
2016-09-11 08:12:48 UTC
> [42/429] python ../../tools/gn/last_commit_position.py ../../ gen/tools/gn/last_commit_position.h TOOLS_GN_LAST_COMMIT_POSITION_H_
> FAILED: gen/tools/gn/last_commit_position.h
> python ../../tools/gn/last_commit_position.py ../../ gen/tools/gn/last_commit_position.h TOOLS_GN_LAST_COMMIT_POSITION_H_
> Traceback (most recent call last):
> File "../../tools/gn/last_commit_position.py", line 96, in <module>
> value = FetchCommitPosition(git_directory)
> File "../../tools/gn/last_commit_position.py", line 64, in FetchCommitPosition
> line = proc.stdout.readline()
> AttributeError: 'NoneType' object has no attribute 'stdout'
> [43/429] python ../../build/write_build_date_header.py gen/base/generated_build_date.h default
> ninja: build stopped: subcommand failed.
> Command '['ninja', '-C', '/var/tmp/portage/www-client/chromium-54.0.2840.16/work/chromium-54.0.2840.16/out/Release', '-v', 'gn']' returned non-zero exit status 1
Comment on attachment 445454 [details]
build.log
No need to compress logs when under 1M.
Created attachment 445482 [details]
build log
It appears this python script is trying to read the output of "git log". I can reproduce the problem after uninstalling dev-vcs/git. commit 9fbf495a92753d0b91a6ebab3652fa748ab690bb Author: Mike Gilbert <floppym@gentoo.org> Date: Sun Sep 11 11:25:47 2016 -0400 www-client/chromium: depend on dev-vcs/git Bug: https://bugs.gentoo.org/593476 Package-Manager: portage-2.3.0_p24 www-client/chromium/chromium-54.0.2840.16.ebuild | 2 ++ www-client/chromium/chromium-55.0.2853.0.ebuild | 2 ++ 2 files changed, 4 insertions(+) Created attachment 454038 [details, diff]
patch for unneeded "git log" call
Sorry, I think adding git as an ebuild dependency is an inacceptable "fix". A simple patch really fixes the problem by not calling git at all
(In reply to Andreas Kinzler from comment #6) If you can provide a patch that upstream would be able to merge, I would be happy to help make that happen. It has been fixed by: https://codereview.chromium.org/2237913002/ https://chromium.googlesource.com/chromium/src/+/e9fcf209818dede2348c41913994b5d9ea81314c Thanks to remove the dev-vcs/git dependency as appropriate. www-client/chromium-54.0.2840.100 (current stable version) already includes the patch, so it can be modified. I didn't check the other versions. Ok no sorry, from what I understand, the upstream patch was just for the case where Git cannot find the commit position... Building still fails if Git is not installed and cannot be run at all, with the same error message... |