Summary: | media-sound/mixxx-2.0.0-r1 with qt-5.7 and gcc-5.4.0 - error Qt requires a C++11 compiler and yours does not seem to be that. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | jospezial <jospezial> |
Component: | Current packages | Assignee: | Professional Audio Applications Maintainers <proaudio> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fordfrog |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 589412 |
Description
jospezial
2016-08-07 13:11:00 UTC
Please attach a complete 'build.log' and the output of 'emerge --info'. commit 4cf05fe4fe0741874905961f5ff6a4da5b4d77b1 Author: Lars Wendler <polynomial-c@gentoo.org> Date: Wed Oct 19 16:38:59 2016 media-sound/mixxx: Fixed compilation with >=qt-5.7.0 (bug #590690). Package-Manager: portage-2.3.2 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> (In reply to Lars Wendler (Polynomial-C) from comment #2) > commit 4cf05fe4fe0741874905961f5ff6a4da5b4d77b1 > Author: Lars Wendler <polynomial-c@gentoo.org> > Date: Wed Oct 19 16:38:59 2016 > > media-sound/mixxx: Fixed compilation with >=qt-5.7.0 (bug #590690). > > Package-Manager: portage-2.3.2 > Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> https://github.com/mixxxdj/mixxx/commit/4883aa3f5a1b98da4abc69584c9f96449548f33a "Switch from C++11 to C++14" Please remove or change the fix of this bug. (In reply to jospezial from comment #3) > https://github.com/mixxxdj/mixxx/commit/ > 4883aa3f5a1b98da4abc69584c9f96449548f33a > "Switch from C++11 to C++14" > > Please remove or change the fix of this bug. could you please explain what exactly are you suggesting? we don't have version 2.0.0-r1 in the tree anymore and the patch you are referring was committed before 2.2.3 (the lowest version that we have in the tree) was released so i suppose it already contains it. (In reply to Miroslav Šulc from comment #4) > (In reply to jospezial from comment #3) > > https://github.com/mixxxdj/mixxx/commit/ > > 4883aa3f5a1b98da4abc69584c9f96449548f33a > > "Switch from C++11 to C++14" > > > > Please remove or change the fix of this bug. > > could you please explain what exactly are you suggesting? we don't have > version 2.0.0-r1 in the tree anymore and the patch you are referring was > committed before 2.2.3 (the lowest version that we have in the tree) was > released so i suppose it already contains it. The ebuilds we have in the tree still have these lines: # Required for >=qt-5.7.0 (bug #590690) append-cxxflags -std=c++11 Should it be changed to c++14 or removed because upstream now sets it anyway? I'm working on a cmake based ebuild for mixxx. I see -std=gnu++17 in build.log. sys-devel/gcc-10.2.0-r1 dev-util/cmake-3.18.1 current scons based 2.2.4 has -std=c++11 and 9999 has -std=c++17 so i will drop it from these two ebuilds to not override their settings. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c6c2085af4e8ad7d46b2a91da0c9cb03f699d9d commit 3c6c2085af4e8ad7d46b2a91da0c9cb03f699d9d Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2020-08-28 10:51:12 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2020-08-28 10:51:30 +0000 media-sound/mixxx: 'append-cxxflags -std=c++11' not needed anymore Closes: https://bugs.gentoo.org/590690 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/mixxx/mixxx-2.2.4.ebuild | 3 --- media-sound/mixxx/mixxx-9999.ebuild | 3 --- 2 files changed, 6 deletions(-) Thank you. There it is. https://github.com/mixxxdj/mixxx/commit/24affc9376c2d16d459e2464d0277cbd42880e14 "Switch from C++14 to C++17" |