Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 589796

Summary: sys-fs/eudev: Prefix support
Product: Gentoo Linux Reporter: Benda Xu <heroxbd>
Component: Current packagesAssignee: eudev team <eudev>
Status: RESOLVED FIXED    
Severity: normal CC: prefix
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 315803    
Attachments: eudev-prefix.patch

Description Benda Xu gentoo-dev 2016-07-27 03:09:09 UTC
Created attachment 441670 [details, diff]
eudev-prefix.patch

Hi, this patch make eudev to be configured with correct Prefix directories.  Please have a look.  Thanks!


--exec-prefix is by default set to --prefix in configure, which in turn is by default set by econf.  Therefore it is not needed.
Comment 1 Benda Xu gentoo-dev 2016-08-01 01:49:26 UTC
Hi, I am going to land the patch in tree in a week if there is no objections.
Comment 2 Ian Stakenvicius (RETIRED) gentoo-dev 2016-08-01 01:52:27 UTC
Go for it.  I don't have commit access for another couple of days otherwise I would do it.

Blueness, any objections?
Comment 3 Benda Xu gentoo-dev 2016-08-01 04:32:20 UTC
(In reply to Benda Xu from comment #0)
> Created attachment 441670 [details, diff] [details, diff]
> eudev-prefix.patch
> 
> Hi, this patch make eudev to be configured with correct Prefix directories. 
> Please have a look.  Thanks!
> 
> --exec-prefix is by default set to --prefix in configure, which in turn is
> by default set by econf.  Therefore it is not needed.

Sorry, at a second thought --exec-prefix=${EPREFIX} is needed here. Because --prefix defaults to ${EPREFIX}/usr, not as intended here.

(In reply to Ian Stakenvicius from comment #2)
> Go for it.  I don't have commit access for another couple of days otherwise
> I would do it.

Thanks again Ian.

> Blueness, any objections?

Cool, I will act after having blueness' ack.
Comment 4 Anthony Basile gentoo-dev 2016-08-01 04:50:26 UTC
(In reply to Benda Xu from comment #3)
> (In reply to Benda Xu from comment #0)
> > Created attachment 441670 [details, diff] [details, diff] [details, diff]
> > eudev-prefix.patch
> > 
> > Hi, this patch make eudev to be configured with correct Prefix directories. 
> > Please have a look.  Thanks!
> > 
> > --exec-prefix is by default set to --prefix in configure, which in turn is
> > by default set by econf.  Therefore it is not needed.
> 
> Sorry, at a second thought --exec-prefix=${EPREFIX} is needed here. Because
> --prefix defaults to ${EPREFIX}/usr, not as intended here.
> 
> (In reply to Ian Stakenvicius from comment #2)
> > Go for it.  I don't have commit access for another couple of days otherwise
> > I would do it.
> 
> Thanks again Ian.
> 
> > Blueness, any objections?
> 
> Cool, I will act after having blueness' ack.

go for it.