Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 589486

Summary: net-fs/netatalk: use of REPLACING_VERSIONS does not account for multiple values
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Justin Lecher (RETIRED) <jlec>
Status: RESOLVED FIXED    
Severity: QA Keywords: QAcanfix
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 589444    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-07-23 12:47:47 UTC
See the tracker bug.

  if [[ ${REPLACING_VERSIONS} < 3 ]]; then

This doesn't account for RV being empty or having >1 value. Furthermore, < is lexicographical string comparison, so 10 < 3.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2016-10-23 20:53:21 UTC
commit 67c8fba9a98da19f01e21f6c322d95097bd5aeb7
Author: Justin Lecher <jlec@gentoo.org>
Date:   Sun Oct 23 22:52:49 2016 +0200

    net-fs/netatalk: Properly use REPLACING_VERSIONS

    Drop old

    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=589486

    Package-Manager: portage-2.3.2
    Signed-off-by: Justin Lecher <jlec@gentoo.org>

    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=67c8fba9a98da19f01e21f6c322d95097bd5aeb7