| Summary: | mail-filter/MailScanner-5.0.2 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Philip Taffner <sabel> |
| Component: | Current packages | Assignee: | Patrick Lauer <patrick> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | michael, mlist |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
updated ebuild for 5.0.3-7
Updated MailScanner start script updated ebuild for MailScanner-5.0.3-7 updated start script for MailScanner-5.0.3-7 patch for ms-check to get Gentoo-compliant README.Gentoo documenting differences to stock behaviour updated ebuild for v5.2.1-1 |
||
|
Description
Philip Taffner
2016-05-30 11:14:02 UTC
The whole config handling needs to be rewritten, some obvious changes are: 12c13 < SRC_URI="http://www.mailscanner.info/files/4/tar/${PN}-install-${MY_PVR}.tar.gz" --- > SRC_URI="https://s3.amazonaws.com/msv5/release/${PN}-${MY_PVR}.nix.tar.gz" 51c52 < S="${WORKDIR}/${PN}-${MY_PVR}" --- > S="${WORKDIR}/${PN}-${MY_PV}" Created attachment 453156 [details]
updated ebuild for 5.0.3-7
I have this updated ebuild running locally.
After looking into the /etc/MailScanner/conf.d functionality I decided to drop upgrading of the config file in pkg_postinst() and put my local settings into an /etc/MailScanner/conf.d/local.conf instead. No idea how this could be automated for upgrades from 4.x but it seems a much more elegant and painless way of handling local adjustments to me: etc-update will point out changes in MailScanner.conf and the user either merges to leav the old fragment in or updates their local.conf accordingly.
I'm not happy with how /usr/sbin/ms-update-bad-emails and /usr/sbin/ms-update-sa unconditionally call /usr/lib/MailScanner/init/ms-init restart. Because they're (potentially) part of the regular cron jobs they may cause MailScanner to start even though it's not actually supposed to run. For now it's not a problem because run_mailscanner defaults to 0 in /etc/conf.d/MailScanner effectively disabling ms-init.
Which opens another bag of cats: I think we should drop all the settings from conf.d/MailScanner that we don't need to avoid user confusion.
Created attachment 453158 [details]
Updated MailScanner start script
This updated MailScanner start script uses start-stop-daemon's --retry option with "SIGTERM/30 SIGKILL/1". This way I don't seem to need the sleep $RESTART_DELAY on restarts any more and eliminated it together with it's now totally unused friend UPDATEMAXDELAY from /etc/conf.d/MailScanner.
Created attachment 453222 [details]
updated ebuild for MailScanner-5.0.3-7
Did another pass, solving all my previous niggles to my satisfaction.
Created attachment 453224 [details]
updated start script for MailScanner-5.0.3-7
- drop useless /var/lock/subsys/MailScanner
- use ms-peek to get path to PID file
- use automagically available settings from conf.d
- drop default-matching restart() and add reload() using SIGHUP
Created attachment 453226 [details, diff]
patch for ms-check to get Gentoo-compliant
see top of patch for rationale
Created attachment 453228 [details]
README.Gentoo documenting differences to stock behaviour
Created attachment 597986 [details]
updated ebuild for v5.2.1-1
Attached is an updated ebuild for the current version.
|
