| Summary: | sys-apps/portage: eapply_user: do not fail on empty patch directory | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Till Schäfer <till2.schaefer> |
| Component: | Unclassified | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
*** This bug has been marked as a duplicate of bug 573920 *** |
Currently portage is failing for EAPI 6 ebuilds, when an empty patch directory is present. From my point of view there is no (obvious) reason to fail in this situation. Failing, just makes it harder to test patches, e.g. by comparing the unpatched version against a patched version of the package. Example: having an empty folder "/etc/portage/patches/kde-misc/yakuake" leads to a failing build of yakuake: >>> Preparing source in /var/tmp/portage/kde-misc/yakuake-3.0.2/work/yakuake-3.0.2 ... * ERROR: kde-misc/yakuake-3.0.2::gentoo failed (prepare phase): * No *.{patch,diff} files in directory /etc/portage/patches/kde-misc/yakuake * * Call stack: * ebuild.sh, line 133: Called src_prepare * environment, line 3702: Called kde5_src_prepare * environment, line 2752: Called cmake-utils_src_prepare * environment, line 1016: Called _cmake_execute_optionally 'src_prepare' * environment, line 467: Called enable_cmake-utils_src_prepare * environment, line 1443: Called default_src_prepare * phase-functions.sh, line 834: Called __eapi6_src_prepare * environment, line 305: Called eapply_user * environment, line 1210: Called eapply '/etc/portage/patches/kde-misc/yakuake' * environment, line 1184: Called die * The specific snippet of code: * [[ -z ${files[@]} ]] && die "No *.{patch,diff} files in directory ${f}";