Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 579358 - sys-apps/portage: eapply_user: do not fail on empty patch directory
Summary: sys-apps/portage: eapply_user: do not fail on empty patch directory
Status: RESOLVED DUPLICATE of bug 573920
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-08 17:09 UTC by Till Schäfer
Modified: 2016-04-08 17:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Till Schäfer 2016-04-08 17:09:58 UTC
Currently portage is failing for EAPI 6 ebuilds, when an empty patch directory is present. From my point of view there is no (obvious) reason to fail in this situation. Failing, just makes it harder to test patches, e.g. by comparing the unpatched version against a patched version of the package. 


Example: having an empty folder "/etc/portage/patches/kde-misc/yakuake" leads to a failing build of yakuake: 

>>> Preparing source in /var/tmp/portage/kde-misc/yakuake-3.0.2/work/yakuake-3.0.2 ...
 * ERROR: kde-misc/yakuake-3.0.2::gentoo failed (prepare phase):
 *   No *.{patch,diff} files in directory /etc/portage/patches/kde-misc/yakuake
 *
 * Call stack:
 *            ebuild.sh, line  133:  Called src_prepare
 *          environment, line 3702:  Called kde5_src_prepare
 *          environment, line 2752:  Called cmake-utils_src_prepare
 *          environment, line 1016:  Called _cmake_execute_optionally 'src_prepare'
 *          environment, line  467:  Called enable_cmake-utils_src_prepare
 *          environment, line 1443:  Called default_src_prepare
 *   phase-functions.sh, line  834:  Called __eapi6_src_prepare
 *          environment, line  305:  Called eapply_user
 *          environment, line 1210:  Called eapply '/etc/portage/patches/kde-misc/yakuake'
 *          environment, line 1184:  Called die
 * The specific snippet of code:
 *               [[ -z ${files[@]} ]] && die "No *.{patch,diff} files in directory ${f}";
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-04-08 17:13:24 UTC

*** This bug has been marked as a duplicate of bug 573920 ***