| Summary: | net-p2p/tribler: version bump and readd | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Perfect Gentleman <perfect007gentleman> |
| Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | CC: | gentoo, jstein, pacho, proxy-maint, tonemgub, treecleaner |
| Priority: | Normal | Keywords: | PMASKED |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=613892 https://bugs.gentoo.org/show_bug.cgi?id=232651 |
||
| Whiteboard: | Pending removal: 2018-04-13 | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 640888 | ||
| Bug Blocks: | 587112, 611638, 613892 | ||
| Attachments: |
New ebuild for tribler v6.5.2
Patch to fix desktop menu Patch to adhere to the XDG standard New tribler-6.5.2.ebuild Fixed tribler-6.5.2.ebuild tribler-7.0.2.ebuild tribler-fix-desktop.patch tribler-xdg.patch |
||
|
Description
Perfect Gentleman
2016-02-16 10:39:44 UTC
I'm probably going to just drop this package. The code base is very hard to work with. If you want to suggest an ebuild okay, but I'm not going to spend any time on this. just for the record: https://github.com/Tribler/tribler/releases/tag/v6.5.2 Upstream could clean the source package on github from unnecessary files... (In reply to Jonas Stein from comment #2) > just for the record: > https://github.com/Tribler/tribler/releases/tag/v6.5.2 > > Upstream could clean the source package on github from unnecessary files... I'm not sure what you mean. I've wasted a lot of time on this poorly coded packages and really don't want to waste more. If you want to suggest a working ebuild I'll consider it. Created attachment 449832 [details]
New ebuild for tribler v6.5.2
Created attachment 449834 [details, diff]
Patch to fix desktop menu
Created attachment 449838 [details, diff]
Patch to adhere to the XDG standard
The old ebuilds actually present in the Portage's tree don't work any more because Tribler requires python2 dependencies that the ebuilds do not honour; fixing those old ebuilds is just a waste of time (IMHO), so I suggest to remove them (or hard mask them) and keep my new ebuild only. So far I tested Tribler v6.5.2 for a few weeks, and used only a few of its features, and it seems to work correctly. However, more testing is required for the advanced features. this is also needed to stop relying on obsolete python eclasses @blueness, I presume you wouldn't mind a proxied maintainer taking this over? @Toffanin, would you be interested in maintaining this package via the proxy-maint project? If yes, would you consider submitting a pull request with your ebuild and adding yourself + proxy-maint project at [1]? [1]:https://github.com/gentoo/gentoo/pulls (In reply to Michał Górny from comment #9) > @blueness, I presume you wouldn't mind a proxied maintainer taking this over? > > @Toffanin, would you be interested in maintaining this package via the > proxy-maint project? If yes, would you consider submitting a pull request > with your ebuild and adding yourself + proxy-maint project at [1]? > > [1]:https://github.com/gentoo/gentoo/pulls not at all, i've resisted updating it because it had lots of problems and was hoping that usptream would clean up their act. @toffanin, please submit a pull request and i'll take care of it from there. please also note bug #613892 Created attachment 476216 [details]
New tribler-6.5.2.ebuild
net-libs/rb_libtorrent moved to libtorrent-rasterbar
Updated ebuild attached
Created attachment 476230 [details]
Fixed tribler-6.5.2.ebuild
dev-libs/libsodium dependency was missing as well so I added it. It is working for me now.
(In reply to Jess Haas from comment #12) > Created attachment 476230 [details] > Fixed tribler-6.5.2.ebuild > > dev-libs/libsodium dependency was missing as well so I added it. It is > working for me now. you need to give me the patches (In reply to Anthony Basile from comment #13) > (In reply to Jess Haas from comment #12) > > Created attachment 476230 [details] > > Fixed tribler-6.5.2.ebuild > > > > dev-libs/libsodium dependency was missing as well so I added it. It is > > working for me now. > > you need to give me the patches ping. i need your patches to put this on the tree. *** Bug 631576 has been marked as a duplicate of this bug. *** Created attachment 527116 [details] tribler-7.0.2.ebuild Version is up to 7.0.2 Here is an updated ebuild for it. This requires dev-python/meliae-0.4.0 I just submitted a new ebuild for that in Bug 408217. Created attachment 527118 [details, diff]
tribler-fix-desktop.patch
New patch updated for 7.0.2
Created attachment 527120 [details, diff]
tribler-xdg.patch
New patch updated for 7.0.2
removed Why is this being removed? I provided a working ebuild for the current version.... Sorry for the communication issue... I had lots of bugs at the same time and... The removal is because it needs some more work... The main blocker is that for adding the new package that it needs as a dependency we need that package to have a maintainer. Anyway, if you send all to proxy maintainers, you could proxy maintain both packages https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers But for this ebuild: 1. It should use eapi6 if possible 2. I am not sure about if it solves bug 640888 3. fdo-mime eclass is deprecated in favor of xdg.eclass 4. Inherit the full eutils.eclass only to call menu entries functions is a bit overkill: you have desktop.eclass for that. They are exactly providing the same functions and, in the future, all will need to inherit desktop.eclass directly for that What I recommend you to get this solved faster: - I would open a github pull request adding the new package that is needed by this and the updated ebuild and metadata with you as new maintainer. - You can also add a link to the PR to "See also:" field here in the bug I guess they (proxy-maint maintainers) will reply to you soon, please remember to provide one commit per file: one for the new package, other for adding the new version of tribler... Thanks Not sure if I will have time to deal with it myself for the next couple months as work is going to keep me mosyly away from the computer. If anyone else wants to step up feel free. If not I will try to find the time at some point. Removed from the tree in April. |
