Summary: | app-editors/scite does not respect CXX | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Ervin Peters <ervin.peters> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | proxy-maint |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 577882 | ||
Attachments: |
updated scite-3.6.2-r1 ebuild
updated scite-3.6.2 ebuild with proposed changes |
Description
Agostino Sarubbo
2015-12-28 15:25:41 UTC
Could someone explain that issue or give me some hints? It seems to me that the makefile patches in src_prepare should be modified. ervin here's a giant hint emake V=1 CC="$(tc-getCC)" LDFLAGS="$(raw-ldflags)" LD="$(tc-getLD)" -C xen ${myopt} toolchain-funcs.eclass Admittedly, the description does not respect CXX lacks any clear or obvious meaning to my reckoning. Created attachment 433072 [details] updated scite-3.6.2-r1 ebuild OA issues anc cosmetic things fix see also bug #581220 Ervin: You have been caught here with the D vs. ED issue. For the sake of consistency, as with the bumped 3.6.5, can you set D -> ED in src_install. It seems both would be valid. You have also set the deps that take slotting to :* x11-libs/cairo has no alternate slots. SLOT="0" set for all. x11-libs/gdk-pixbuf takes only SLOT="2" x11-libs/pango also is not slotted; SLOT="0" set for all. Given no competition I can see no need for the addition of the ":*". You appear to have blindly added it to any and all. Also there in no need to revbump. The change to "respect CXX"xxx amounts to a build issue and warrants no revbump. In addition to Ian's comment 4, there is a dependency listed in DEPEND that does not need to be there due to being included in the @system set (specifically, sys-apps/sed). This is known as an "Implicit System Dependency" [0]. This should be removed. I missed this when I was reviewing bug 581220. If you can fix this in the ebuild here, we will fix the other ebuilds accordingly when we commit this. So in summary: - x11-libs/cairo does not need a SLOT operator - x11-libs/gdk-pixbuf does not need a SLOT operator - x11-libs/pango does not need a SLOT operator - x11-libs/gtk+ should have a "rebuild-on-change" operator (x11-libs/gtk+:2=) - sys-apps/sed should be removed from DEPEND Thanks! Sigh, always forgetting my references... :D Implicit System Dependencies: [0] https://devmanual.gentoo.org/general-concepts/dependencies/#implicit-system-dependency Created attachment 433190 [details]
updated scite-3.6.2 ebuild with proposed changes
Thanks for your advice. I changed it and it compiles fine. I do not yet really understand why all this details, e.g. why to recompile scite in case of an updated gtk+, but as long as it works it is ok.
As you might have recognized this ebuild should work for nearly all scite versions from 3.5.5 on.
ervin
(In reply to Ervin Peters from comment #7) \ > Thanks for your advice. I changed it and it compiles fine. I do not yet > really understand why all this details, e.g. why to recompile scite in case > of an updated gtk+, but as long as it works it is ok. > Well you may not understand fully, just accept the deps of this package under the rules and flow of slotting make it complex. These steps are making the ebuild consistent with the complex rules of ebuild writing. There is much documentation available in gentoo which can further inform if you care to pursue. > As you might have recognized this ebuild should work for nearly all scite > versions from 3.5.5 on. > > ervin Thank you for your contribution. commit 2690da7b461c7042a1cfbb033462a62f679611ca Author: Ian Delaney <idella4@gentoo.org> Date: Thu May 5 14:39:14 2016 +0800 app-editors/scite: fixes to vn. 3.6.2 sourced from gentoo bug - inherit toolchain-funcs eclass to ensure the build to 'respect CXX', - add slot operators to deps requiring them (glib, gtk+, lua) - removed dep sed from deps (set in @system) fixes the gentoo bug Gentoo-bug: #Bug 569986 |