| Summary: | www-servers/spawn-fcgi init script doesn't detect crash | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Cédric Krier <cedk> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | PATCH |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 618090 | ||
| Attachments: |
spawn-fcgi.initd-r3
spawn-fcgi.diff spawn-fcgi.diff |
||
Could you provide a diff? For me, it shoud be a new init script so I don't see against what it should be "diffed". Diff against -r2, so it's more obvious what you have changed. Created attachment 418742 [details, diff]
spawn-fcgi.diff
Here is the diff.
Created attachment 418744 [details, diff]
spawn-fcgi.diff
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e087bd09a7b0d4737e26c876720a596ed002d28 commit 0e087bd09a7b0d4737e26c876720a596ed002d28 Author: Pacho Ramos <pacho@gentoo.org> AuthorDate: 2018-10-14 08:43:27 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2018-10-14 10:18:04 +0000 www-servers/spawn-fcgi: Several fixes to init.d script - Detect crashes (#567320 by Cédric Krier) - Use proper variable names (#657362 by Jernej Simoncic) Closes: https://bugs.gentoo.org/567320 Closes: https://bugs.gentoo.org/657362 Signed-off-by: Pacho Ramos <pacho@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 www-servers/spawn-fcgi/files/spawn-fcgi.initd-r3 | 116 ++++++++++++++++++++++ www-servers/spawn-fcgi/spawn-fcgi-1.6.4-r1.ebuild | 33 ++++++ 2 files changed, 149 insertions(+) |
Created attachment 418322 [details] spawn-fcgi.initd-r3 The script use env and --name option which prevents OpenRC to detect crash. Here is in attachment an improved version of the script which remove the --name option and use --env of start-stop-daemon instead of using env command.