| Summary: | =media-libs/libass-0.13.0: update blockers as enca USE was dropped | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Coacher <itumaykin+gentoo> |
| Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ansla80, ave, chalucha, cristiano04, dschridde+gentoobugs, gentoo, ibuyandtrade0+bugs.gentoo.org, josef64, jouni.kosonen, jrmalaq, maksbotan, pageexec, polynomial-c, rzubaly, tetromino, yngwin |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Coacher
2015-10-06 12:06:59 UTC
https://github.com/libass/libass/releases/tag/0.13.0 "Drop ENCA support" Will MPV drop enca too? media-video/mplayer-1.2-r1 has libass dependency adjusted wrt this issue. There was an attempt to fix media-video/mpv-0.11.0 libass dependency as well [0]. But I believe it went wrong and libass dependency should be adjusted to: >=media-libs/libass-0.12.1:=[enca(+)?,fontconfig] Notice use dependency default changed to enca(+). Otherwise it is impossible to install >=media-libs/libass-0.13.0 and >=media-video/mpv-0.11.0[enca] simultaneously. [0]: https://gitweb.gentoo.org/repo/gentoo.git/commit/media-video/mpv?id=d3a0ebbed071c3ae4fd31cea80f6f028041c7708 CC-ing mpv and libass maintainers. Is libass[enca] really required for mpv[enca]? Because I don't see any checks for that in mpv-0.11.0 wscript. And building libass with/without enca support doesn't change libass's public headers in any way, so it's not clear why that dependency would be needed by mpv's code. (In reply to Coacher from comment #3) > There was an attempt to fix media-video/mpv-0.11.0 libass dependency as well > [0]. > But I believe it went wrong and libass dependency should be adjusted to: > > >=media-libs/libass-0.12.1:=[enca(+)?,fontconfig] > > Notice use dependency default changed to enca(+). Otherwise it is impossible > to install >=media-libs/libass-0.13.0 and >=media-video/mpv-0.11.0[enca] > simultaneously. > > [0]: > https://gitweb.gentoo.org/repo/gentoo.git/commit/media-video/ > mpv?id=d3a0ebbed071c3ae4fd31cea80f6f028041c7708 Works fine with this change on my amd64 machine. Confirmed with mpv devs (lachs0r) on IRC that mpv does not require libass with enca enabled for its own enca support to work. *** Bug 565420 has been marked as a duplicate of this bug. *** https://github.com/mpv-player/mpv/commit/384b13c5fd3fa87bad4bedbb3db369cdfb05de2b " demux_libass: remove this demuxer This loaded external .ass files via libass. libavformat's .ass reader is now good enough, so use that instead. Apparently libavformat still doesn't support fonts embedded into text .ass files, but support for this has been accidentally broken in mpv for a while anyway. (And only 1 person complained.) " This commit is not included in mpv 0.13.0 release. (In reply to jospezial from comment #9) > https://github.com/mpv-player/mpv/commit/ > 384b13c5fd3fa87bad4bedbb3db369cdfb05de2b > > This commit is not included in mpv 0.13.0 release. Can this commit be backported into media-video/mpv-0.13.0? See-Also: https://bugs.gentoo.org/show_bug.cgi?id=564656 *** Bug 568370 has been marked as a duplicate of this bug. *** commit 85ad9a8c6518f2db5cbd2d050b3e4052e4254f40 Author: Ilya Tumaykin <itumaykin@gmail.com> Date: Tue Dec 22 20:59:38 2015 +0300 media-video/mpv: adjust required libass USE flags wrt bug 562394 mpv uses libass to render subtitles and enca to detect subtitle encoding. For mpv to support enca, mpv does not need to have libass[enca]. This helps to avoid problems with >=libass-0.13.0, which dropped 'enca' USE. Also enable harfbuzz USE to support subtitles for complex languages. See [0] as a reference for both of the above. [0]: https://github.com/mpv-player/mpv/blob/master/DOCS/man/options.rst Gentoo-Bug: 562394 Package-Manager: portage-2.2.24 This fix is included in mpv versions 0.11.0-r1, 0.14.0, 9999. Closing as fixed. |
