Summary: | dev-util/catalyst: Create /etc/portage/repos.conf/gentoo.conf in stages | ||
---|---|---|---|
Product: | Gentoo Release Media | Reporter: | Neil <nshephard> |
Component: | Stages | Assignee: | Gentoo Catalyst Developers <catalyst> |
Status: | CONFIRMED --- | ||
Severity: | minor | CC: | arfrever.fta, dev-portage, esigra, gentoo, maffblaster, mattst88, mscardovi, pacho, releng |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=730502 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 546210, 726334 | ||
Attachments: |
catalyst-repos.conf.patch
patch review catalyst-repos.conf.patch catalyst-repos.conf.patch |
Description
Neil
2015-09-15 08:48:54 UTC
Created attachment 418818 [details, diff]
catalyst-repos.conf.patch
I attach untested patch for master branch of Catalyst.
Created attachment 420854 [details, diff]
patch review
I've gotten this one reviewed. Mostly good, just a couple things to fix.
Thank you
*** Bug 572192 has been marked as a duplicate of this bug. *** This bug should be closed. For wrong behavior of mirrorselect --rsync there is bug 699232. Also, the recommendation for changing the rsync mirror could be changed to using "eselect repository" instead of "mirrorselect --rsync": touch /etc/portage/repos.conf eselect repository add gentoo rsync <rsync-uri> Problem is still present in newest stages (e.g. stage3-amd64-20191103T214502Z.tar.xz): etc/portage/make.conf contains deprecated PORTDIR=... assignment. etc/portage/repos.conf is missing. (In reply to Brian Dolbec from comment #3) > Created attachment 420854 [details, diff] [details, diff] > patch review > > I've gotten this one reviewed. Mostly good, just a couple things to fix. > > Thank you I'll pick this up, tidy, and see if I can get merged. (In reply to Arfrever Frehtes Taifersar Arahesis from comment #2) > Created attachment 418818 [details, diff] [details, diff] > catalyst-repos.conf.patch > > I attach untested patch for master branch of Catalyst. If you wouldn't mind rebasing this on 5 years of development, I'll see that it gets tested and committed. Created attachment 657204 [details, diff]
catalyst-repos.conf.patch
Created attachment 657206 [details, diff]
catalyst-repos.conf.patch
(First patch was using `rm -fr`. Second patch was using clear_dir(), but clear_dir() on non-existent target would print warning, so third patch calls ensure_dirs() before clear_dir(). clear_dir(remove=False) internally also calls ensure_dirs().)
Alternative changes were made in: https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=37a386056f77f7cc8f1c2bdfe680b13bd806b4e6 https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=2861038ae8c3c67f3000c976ed8177f63169712c https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=d5f85bc8d71d89920332ce760e5da3dca257dc36 https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=25a7af61391e3fa8af77beec26c95b03175342d9 https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=caf55a942580e02e66ed846f5c3ab4ad5ab8846f https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=65d49f1028b49fed6e011526429e553ebb6c903e https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=5f34226550e221921189ca2184a0afe2de1e8821 These changes were made in branch "master", not in branch "catalyst-3.0-stable" which was used for recent releases... *** Bug 800842 has been marked as a duplicate of this bug. *** |