Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 558310

Summary: app-admin/collectd - Use the Java eclasses
Product: Gentoo Linux Reporter: James Le Cuirot <chewi>
Component: Current packagesAssignee: Johan Bergström <bugs>
Severity: normal CC: java, proxy-maint
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 549508    
Attachments: Patch against collectd-5.4.1-r1.ebuild

Description James Le Cuirot gentoo-dev 2015-08-20 21:00:57 UTC
Created attachment 409702 [details, diff]
Patch against collectd-5.4.1-r1.ebuild

Java team needs to remove java-config-wrapper, which this erroneously depends on. The existing ebuild does not make use of the Java eclasses, which can lead to problems. I have:

 * Made use of java-pkg-opt-2.
 * Added a DEPEND on virtual/jdk because javac, jar and JNI headers are required.
 * Used sed against the Java to set proper -source and -target flags.
 * Used the eclasses to properly set JAVA_HOME instead of calling java-config.
 * Registered the installed jars so that Gentoo metadata is created, allowing other packages to locate them and use the correct Java version against them.

If no one complains within 2 weeks, I'll commit these changes myself.
Comment 1 James Le Cuirot gentoo-dev 2015-08-20 22:01:48 UTC
Forgot to mention that the older ebuilds should probably be removed in the process as they are unused.
Comment 2 James Le Cuirot gentoo-dev 2015-09-03 09:01:19 UTC
Time up! Committed.