| Summary: | media-libs/gst-plugins-good:0.10 fails to build with clang | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Julian Ospald <hasufell> |
| Component: | Current packages | Assignee: | GStreamer package maintainers <gstreamer> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | clang+obsolete |
| Priority: | Normal | Keywords: | Inclusion, PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://svnweb.freebsd.org/ports/head/multimedia/gstreamer-plugins-good/files/patch-gst_goom_mmx.h?revision=311892&view=markup | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 408963 | ||
| Attachments: |
1439898534-install-media-libs_gst-plugins-good-0.10.31-r1:0.10::gentoo.out
cave-info.txt |
||
Created attachment 409352 [details]
cave-info.txt
Does gst-plugins-good-1.4.5 work? It is unlikely that any fix will happen to 0.10 - it is not maintained upstream and Gentoo goal is to get rid of all users of 0.10 slots, and have everything use the 1.0 slots instead. As such, we would need to wait the cleansing of 0.10, or a straightforward patch to fix it, possibly a cherry-pick from gstreamer git commits, but from interested parties - I'm only interested if :1.0 is affected. If you have a clean patch, feel free to apply it yourself carefully. (In reply to Mart Raudsepp from comment #2) > Does gst-plugins-good-1.4.5 work? yes This is the freebsd patch for this, can you try it? If it works for your, feel free to go ahead and commit: http://svnweb.freebsd.org/ports/head/multimedia/gstreamer-plugins-good/files/patch-gst_goom_mmx.h?revision=311892&view=markup (In reply to Pacho Ramos from comment #4) yes, that patch works I have verified that the patch applies cleanly and works properly: gst-plugins-good-0.10.31-r1 compiles fine and passes tests both with clang-3.7.0 and gcc-4.9.3. (In reply to Fabio Scaccabarozzi from comment #6) > I have verified that the patch applies cleanly and works properly: > gst-plugins-good-0.10.31-r1 compiles fine and passes tests both with > clang-3.7.0 and gcc-4.9.3. Works for me as well. (In reply to Pacho Ramos from comment #4) > This is the freebsd patch for this, can you try it? If it works for your, > feel free to go ahead and commit: > http://svnweb.freebsd.org/ports/head/multimedia/gstreamer-plugins-good/files/ > patch-gst_goom_mmx.h?revision=311892&view=markup I don't know why Julian didn't commit this, but now that I can, I went ahead and did so: https://github.com/gentoo/gentoo/commit/4231143b2a29252a293bdac1fcfb90d08dd3fb86 |
Created attachment 409350 [details] 1439898534-install-media-libs_gst-plugins-good-0.10.31-r1:0.10::gentoo.out /var/tmp/paludis/media-libs-gst-plugins-good-0.10.31-r1/work/gst-plugins-good-0.10.31/gst/goom/mmx.c:132:5: error: clobbers must be last on the x87 stack emms (); ^ /var/tmp/paludis/media-libs-gst-plugins-good-0.10.31-r1/work/gst-plugins-good-0.10.31/gst/goom/mmx.h:723:38: note: expanded from macro 'emms' #define emms() __asm__ __volatile__ ("emms"::: \ ^ /var/tmp/paludis/media-libs-gst-plugins-good-0.10.31-r1/work/gst-plugins-good-0.10.31/gst/goom/mmx.c:282:3: error: clobbers must be last on the x87 stack emms ();