| Summary: | sys-apps/memtest86+-5.01 (and earlier) do not compile with gcc-5.1 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Martin Väth <martin> |
| Component: | [OLD] GCC Porting | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bircoph, holger, jarausch, toralf |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=568292 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 536984 | ||
| Attachments: |
Add -std=gnu90 to fix compilation with gcc-5
build log alternative patch for gcc-5.2.0 |
||
Created attachment 402614 [details]
build log
That patch is still needed for sys-apps/memtest86+-5.01-r1 with sys-devel/gcc-5.2.0 Created attachment 407434 [details, diff]
alternative patch for gcc-5.2.0
(In reply to Helmut Jarausch from comment #3) > Created attachment 407434 [details, diff] [details, diff] > alternative patch for gcc-5.2.0 Works with that patch. @base-system: Please add it the patch to the tree! sys-apps/memtest86 (without plus) fails with same error too. Can someone please push the fix above into the tree? This is the third build failure I encountered today, for which the patch is there but not pushed to the tree. Do we have shortage of gentoo devs in certain areas? Just curious. I haven't seen this abandonment of fixes before. @base-system, is it OK to apply the first patch (--std=gnu90)? Looks like the sanest solution, as breakage is caused by default C std switch to gnu11. Works fine for me here. i've fixed it w/out having to mess with the C standard: http://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e5b24d52ab056fffa21763d8a8ed09c04f4ce539 *** Bug 607692 has been marked as a duplicate of this bug. *** |
Created attachment 402378 [details, diff] Add -std=gnu90 to fix compilation with gcc-5 memtest86+-5.01 relies on C90 behaviour for linking and thus will not link with gcc-5. Apparently, the code uses also special GNU features, so that -std=gnu90 has to be added to the CFLAGS. Since the Makefile ignores passed CFLAGS, a patch (appended) is necesary.