Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 548200

Summary: dev-util/mingw64-runtime: Add support for winpthread via USE=threads
Product: Gentoo Linux Reporter: Bertrand Jacquin <bertrand>
Component: [OLD] DevelopmentAssignee: Gentoo Toolchain Maintainers <toolchain>
Status: RESOLVED FIXED    
Severity: enhancement CC: alonbl, bertrand
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 543954    
Bug Blocks:    
Attachments: mingw64-runtime-3.2.0-r1.ebuild
mingw64-runtime-3.2.0-r1.ebuild.diff

Description Bertrand Jacquin 2015-04-30 01:00:29 UTC
Here is a patch to support winpthread build as long as building mingw64-runtime. A new USE flag is introduced in order to let user enable it or not. This is fully compatible for multi stage build needed for crossdev.

Reproducible: Always
Comment 1 Bertrand Jacquin 2015-04-30 01:02:10 UTC
Created attachment 402254 [details, diff]
mingw64-runtime-3.2.0-r1.ebuild
Comment 2 Bertrand Jacquin 2015-04-30 01:07:30 UTC
Created attachment 402256 [details, diff]
mingw64-runtime-3.2.0-r1.ebuild.diff

Update patch to use default instead of emake
Comment 3 Bertrand Jacquin 2015-04-30 01:57:03 UTC
Side note that it only support lib64 as this is hardcoded, we can get ride of it easily but cannot use get_libdir as it will return "lib" from CTARGET instead of "lib32" and will lead to a bad usage of -B
Comment 4 SpanKY gentoo-dev 2015-05-04 08:29:11 UTC
Comment on attachment 402256 [details, diff]
mingw64-runtime-3.2.0-r1.ebuild.diff

>+IUSE="crosscompile_opts_headers-only idl threads"

should we enable it by default ?

>+		pushd mingw-w64-libraries/winpthreads >&/dev/null || die

only send stdout to /dev/null (drop the &); same for below

>+		# Use crt{begin,end}.o from the WORKDIR
>+		_oLDFLAGS="${LDFLAGS}"

use local here:
  local LDFLAGS=${LDFLAGS}

>+		append-ldflags "-Wc,-B${S}/mingw-w64-crt/lib64"

needs a comment ... and does this work for 32bit ?

>+		LDFLAGS="${_oLDFLAGS}"

delete this per above

>+		popd >&/dev/null || die

drop the & and the die; same for below
Comment 5 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-04 19:27:38 UTC
I added more generic support in bug#543954, please check it out.
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 11:40:57 UTC
Fixed in mingw64-runtime-4.0.1 USE libraries