Summary: | gnome-pilot-2.0.10-r1 fails to compile with gcc-3.4 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jeremy Huddleston (RETIRED) <eradicator> |
Component: | New packages | Assignee: | Jeremy Huddleston (RETIRED) <eradicator> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gnome, pda |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 48528 | ||
Attachments: | gnome-pilot-3.4.patch |
Description
Jeremy Huddleston (RETIRED)
2004-06-11 09:10:05 UTC
Created attachment 33088 [details, diff]
gnome-pilot-3.4.patch
whoops... gnome is the primary herd... That will work, however, just to be picky: <soapbox> Good coding practice demands a single point of exit for any given function. Therefore, a better patch would add a "return;" after the "error:" label, rather than replacing every "goto error;" with a "return;". </soapbox> ;-) martins comment makes sense eradicator but i'm fine with the patch one way or the other, just put it in. ok... I'm rechecking this now and in portage... |