Summary: | gnome2-utils.eclass: incorrect sed script in gnome2_disable_deprecation_warning() | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexander Tsoy <alexander> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | esigra |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=448822 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 262490 | ||
Attachments: | gnome2-utils.eclass.patch |
Description
Alexander Tsoy
2014-11-25 00:29:13 UTC
> + -e 's:-DGSEAL_ENABLE(=[A-Za-z0-9_]*)?:$(NULL):g' \
'_' is unlikely to be used in the real life, so [:alnum:] character class should also work:
+ -e 's:-DGSEAL_ENABLE(=[[:alnum:]]*)?:$(NULL):g' \
(In reply to Alexander Tsoy from comment #1) > > + -e 's:-DGSEAL_ENABLE(=[A-Za-z0-9_]*)?:$(NULL):g' \ > > '_' is unlikely to be used in the real life, so [:alnum:] character class > should also work: > > + -e 's:-DGSEAL_ENABLE(=[[:alnum:]]*)?:$(NULL):g' \ @gnome team, what option do you prefer? :) Per bug 448822 we could probably use "true" instead of $(NULL) to prevent the same warning as bug 448822 I would go with the former plus using /bin/true: + -e 's:-DGSEAL_ENABLE(=[A-Za-z0-9_]*)?:$(/bin/true):g' \ [master ca71627] eclass/gnome2-utils.eclass: fix DGSEAL_ENABLE sed (#530490 by Alexander Tsoy) 1 file changed, 1 insertion(+), 1 deletion(-) |