Summary: | collected missing/optional kde* dependencies | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Carsten Lohrke (RETIRED) <carlo> |
Component: | New packages | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED FIXED | ||
Severity: | major | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
kdelibs-3.3.0-kerberos-support.diff
kdelibs-3.3.0-jasper-openexr.patch |
Description
Carsten Lohrke (RETIRED)
![]() Your job, Caleb. Tested all bugs in question on KDE 3.2.2 :) Hm, forgot one.. kdepim: DEPENDs on net-dialup/gnokii, mobile phone support, status: verified, Bug 40360 And the pisock library for kpilot is missing, too (app-pda/pilot-link iirc) Created attachment 39630 [details, diff] kdelibs-3.3.0-kerberos-support.diff From bug #64053 I made this patch for kdelib-3.3.0 ebuild (probably also for kde 3.2 ebuilds) that adds a new USE "kerberos" (it's a global useflag). When this use is disabled than the also the use of GSSAPI in kdelibs is disabled (also if virtual/krb5 is installed) If it's enabled it adds the dependencies of virtual/krb5. In gentoo the 2 virtuals are mit-krb5 and heimdal both supported by kdelibs. > kdegraphics:
> DEPENDs on media-libs/libungif, eeh, use png instead :), status: libkdeinit_kuickshow.so links libungif.so.4, Bug 40886
I've digged in the code of kdegraphics and noticed that exactly libkdeinit_kuickshow.so is linked to ALL the libraries reported by "imlib-config" and here there's also -lungif:
(from the Makefile.am)
kuickshow_la_LIBADD = $(LIB_KDEPRINT) $(LIB_IMLIB)
and in the Makefile you'll see that:
LIB_IMLIB = -L/usr/lib -lImlib -ljpeg -ltiff -lungif -lpng -lz -lm -lXext -L/usr/X11R6/lib -lSM -lICE -lXext -lX11 ^^^^^^^
This result is reported by "imlib-config --libs" but for me this output is strange (read wrong).
In fact, like every other share library, /usr/lib/libImlib.la already reports this libs as needed:
# Libraries that this one depends upon.
dependency_libs=' /usr/lib/libjpeg.la -ltiff /usr/lib/libungif.la -L/usr/X11R6/lib -lX11 -lpng -lz -lm -lSM -lICE -lXext'
So the program that links Imlib only needs "-lImlib" and all the others are resolved by "ld".
For this strange fact I'd say that libungif is NOT a REAL deps of kdegraphics but of libImlib (the imlib ebuild already manage it correctly) and I think that probably this dep is not needed in kdegraphics. Or we would have to add also the deps to zlib, libpng, libjpeg, libICE etc...
> kdegraphics:
> DEPENDs on >=media-libs/jasper-1.701.0, jpeg2k support, status: my pet, Bug 41933
Look at kdegraphics, the only refer to JASPER is the macro AC_FIND_JASPER provided by the kde admin functions.
BUT this macro is not used in the configure of kdegraphics and then no programs are using it, so I can say that it's NOT a dep of kdegraphics.
But i wasn't quite happy... So I've found that this library is searched in kdelibs and used by kimgio/jp2.cpp, if you look at the code, if HAVE_JASPER is not defined than nothing is compiled.
Is this the case for a new use flag? or the media-libs/jasper dep should be always added?
I'll also add the patch that I'me made for enabling the cvsservice in kdevelop-3.1.0, that you'll find at bug #63008 kerberos patch applied to kdelibs Note: Most of these have been fixed Created attachment 40701 [details, diff]
kdelibs-3.3.0-jasper-openexr.patch
This patch adds the support for jpeg2000 (jasper) and openexr in kdelibs. The
jpeg2k check is taked from the kdegraphics one (which should be removed) and
it's active only on x86. (also if jasper is marked ~ppc and ~amd64)
The openexr is another dep of kdelibs not covered until now.
I've noticed that "media-libs/openexr" is marked only ~x86, so probably before the inclusion of the part of the patch related to it, it should be marked at least "x86" (because kde is stable) and in DEPEND we have to check the arch as it's done with jasper. libkdenetwork needs not only wifi? ( net-wireless/wireless-tools ) but wifi? ( >=net-wireless/wireless-tools-25 ) or it will report an error. Should I open a new bug or is ok here? Also on at least sparc >=net-wireless/wireless-tools-25 aren't stable (the 24 are stable) so the kwifimanager won't be compiled also if the "wifi" use is selected. s/or it will report an error. /or it won't be compiled also if the wifi use is selected. kdegraphics doesn't need 'app-text/xpdf' as it has its own copy inside. All issues covered here are solved now, we can close this bug and open a new one in future if others arise. |