Summary: | media-libs/xvid: please review prefix changes | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christoph Junghans (RETIRED) <junghans> |
Component: | [OLD] Library | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | prefix |
Priority: | Normal | Keywords: | Inclusion, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 315803 | ||
Attachments: | patch against gx86 |
deps are ok, but why not p.use.force pic to disable assembly ? the x32 thing is for having asm in other multilib abis; it seems to me that you're disabling asm on all darwin x86 arches (In reply to Alexis Ballier from comment #1) > deps are ok, but why not p.use.force pic to disable assembly ? the x32 thing > is for having asm in other multilib abis; it seems to me that you're > disabling asm on all darwin x86 arches That is right, darwin's apple-gcc is not capable to compile these assembly instructions. Should we add an asm use flags and mask it on darwin? (In reply to Christoph Junghans from comment #2) > (In reply to Alexis Ballier from comment #1) > > deps are ok, but why not p.use.force pic to disable assembly ? the x32 thing > > is for having asm in other multilib abis; it seems to me that you're > > disabling asm on all darwin x86 arches > That is right, darwin's apple-gcc is not capable to compile these assembly > instructions. > > Should we add an asm use flags and mask it on darwin? pic does exactly that, except enabling it disables asm or are you suggesting to rename it ? Only x64-darwin is affected iirc, we could package.use.force pic there? (In reply to Fabian Groffen from comment #4) > Only x64-darwin is affected iirc, we could package.use.force pic there? i think so + 28 Dec 2014; Christoph Junghans <ottxor@gentoo.org> + darwin/macos/arch/x64/package.use.mask: + masked media-libs/xvid[pic], bug #529584 + + 28 Dec 2014; Christoph Junghans <ottxor@gentoo.org> xvid-1.3.3.ebuild: + added prefix support (bug #529584) + |
Created attachment 389550 [details, diff] patch against gx86 Changes: - fix deps for x86-macos and x64-macos - disable assembly for darwin