Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 529584 - media-libs/xvid: please review prefix changes
Summary: media-libs/xvid: please review prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: Inclusion, PATCH
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2014-11-16 22:37 UTC by Christoph Junghans (RETIRED)
Modified: 2014-12-28 23:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch against gx86 (xvid-1.3.3.ebuild.patch,805 bytes, patch)
2014-11-16 22:37 UTC, Christoph Junghans (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2014-11-16 22:37:51 UTC
Created attachment 389550 [details, diff]
patch against gx86

Changes:
- fix deps for x86-macos and x64-macos
- disable assembly for darwin
Comment 1 Alexis Ballier gentoo-dev 2014-11-17 08:20:06 UTC
deps are ok, but why not p.use.force pic to disable assembly ? the x32 thing is for having asm in other multilib abis; it seems to me that you're disabling asm on all darwin x86 arches
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2014-11-17 18:26:03 UTC
(In reply to Alexis Ballier from comment #1)
> deps are ok, but why not p.use.force pic to disable assembly ? the x32 thing
> is for having asm in other multilib abis; it seems to me that you're
> disabling asm on all darwin x86 arches
That is right, darwin's apple-gcc is not capable to compile these assembly instructions.

Should we add an asm use flags and mask it on darwin?
Comment 3 Alexis Ballier gentoo-dev 2014-11-18 10:22:46 UTC
(In reply to Christoph Junghans from comment #2)
> (In reply to Alexis Ballier from comment #1)
> > deps are ok, but why not p.use.force pic to disable assembly ? the x32 thing
> > is for having asm in other multilib abis; it seems to me that you're
> > disabling asm on all darwin x86 arches
> That is right, darwin's apple-gcc is not capable to compile these assembly
> instructions.
> 
> Should we add an asm use flags and mask it on darwin?

pic does exactly that, except enabling it disables asm

or are you suggesting to rename it ?
Comment 4 Fabian Groffen gentoo-dev 2014-11-18 10:33:08 UTC
Only x64-darwin is affected iirc, we could package.use.force pic there?
Comment 5 Alexis Ballier gentoo-dev 2014-11-18 10:39:35 UTC
(In reply to Fabian Groffen from comment #4)
> Only x64-darwin is affected iirc, we could package.use.force pic there?

i think so
Comment 6 Christoph Junghans (RETIRED) gentoo-dev 2014-12-28 23:20:02 UTC
+  28 Dec 2014; Christoph Junghans <ottxor@gentoo.org>
+  darwin/macos/arch/x64/package.use.mask:
+  masked media-libs/xvid[pic], bug #529584
+
Comment 7 Christoph Junghans (RETIRED) gentoo-dev 2014-12-28 23:24:54 UTC
+  28 Dec 2014; Christoph Junghans <ottxor@gentoo.org> xvid-1.3.3.ebuild:
+  added prefix support (bug #529584)
+