Summary: | app-emacs/csharp-mode-0.7.0-r1: fails to build | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | Current packages | Assignee: | Emacs project <emacs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 536506 | ||
Attachments: |
csharp-mode.el require cl
csharp-mode-0.7.0-emacs-24.4.patch csharp-mode-0.8.6-emacs-24.4.patch |
Description
Diego Elio Pettenò (RETIRED)
2014-11-05 19:35:27 UTC
Newest HOMEPAGE seems to be at <https://code.google.com/p/csharpmode/>. Unfortunately, version 0.8.6 (which announces itself as 0.8.5) doesn't build with Emacs 24.4 either. No visible upstream activity since 2011. # Ulrich Müller <ulm@gentoo.org> (5 Nov 2014) # Does not build with Emacs 24.4. # Last visible upstream activity in 2011. # Masked for removal in 30 days, bug #528374. app-emacs/csharp-mode Created attachment 389662 [details, diff] csharp-mode.el require cl Hi, Please don't delete csharp-mode, AFAIK there are no alternatives and it can be fixed with a one-line patch. Note this patch is only for emacs 24.4. The cl package has been deprecated, and may disappear in future versions of emacs. But upstream is aware of the issue (see https://lists.gnu.org/archive/html/bug-gnu-emacs/2014-10/msg01175.html) and it should be fixed in emacs 24.5; we won't need the patch anymore. Created attachment 389714 [details, diff]
csharp-mode-0.7.0-emacs-24.4.patch
@Andrew: Does attached patch (including a version check for emacs-24.4) fix the problem for you?
(In reply to Ulrich Müller from comment #3) Yes. It compiles and runs fine; code is indented and syntax is highlighted correctly. Should I file a separate bug report for a version bump? Version 0.8.6 adds some nice features. (In reply to Andrew Miller from comment #4) > Yes. It compiles and runs fine; code is indented and syntax is highlighted > correctly. Fixed in CVS and mask removed. > Should I file a separate bug report for a version bump? Version 0.8.6 adds > some nice features. Byte-compilation fails for it though, even if I apply the cl patch. I've tested versions 0.8.6, 0.8.2, and 0.7.5, with no success. Created attachment 389788 [details, diff] csharp-mode-0.8.6-emacs-24.4.patch (In reply to Ulrich Müller from comment #5) > Fixed in CVS and mask removed. Cheers. > > Should I file a separate bug report for a version bump? Version 0.8.6 adds > > some nice features. > > Byte-compilation fails for it though, even if I apply the cl patch. I've > tested versions 0.8.6, 0.8.2, and 0.7.5, with no success. I got it working with this patch, taken from comment #3 at https://code.google.com/p/csharpmode/issues/detail?id=1. I'm not sure whether we should use eval-and-compile or eval-when-compile, I have to read the elisp docs. Also, maybe it should be split into two patches, since it fixes different issues? (In reply to Andrew Miller from comment #6) > Created attachment 389788 [details, diff] [details, diff] > csharp-mode-0.8.6-emacs-24.4.patch > I got it working with this patch, taken from comment #3 at > https://code.google.com/p/csharpmode/issues/detail?id=1. > > I'm not sure whether we should use eval-and-compile or eval-when-compile, > I have to read the elisp docs. Rule of thumb is that it should be eval-and-compile if you enclose existing code with it, and eval-when-compile if you add something new to make it compile. :) (In reply to Andrew Miller from comment #7) > Also, maybe it should be split into two patches, since it fixes different > issues? Should be separate patches for separate issues (so we can drop them separately, if only one of the issues gets fixed in the next upstream version). But can you file a new bug for the version bump please, so I won't forget about the issue? I still get several warnings when byte-compiling, and I have to investigate if we can safely ignore them. |