Bug 522128

Summary:	eutils.eclass: einstalldocs should handle HACKING and MAINTAINERS files too
Product:	Gentoo Linux	Reporter:	Pacho Ramos <pacho>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	mgorny
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=573390
Whiteboard:
Package list:		Runtime testing required:	---

Description Pacho Ramos gentoo-dev

2014-09-04 09:47:02 UTC

We are currently needing to manually set DOCS variable only to include this two files for many gnome packages because seems that they are fairly common then. 

I think would be really useful for us to also handle this two files to allow us to drop lots of DOCS="AUTHORS HACKING MAINTAINERS NEWS README" from ebuilds that are only needed to append this two files :)

Thanks a lot

Comment 1 Samuli Suominen (RETIRED) gentoo-dev

2014-09-09 12:58:19 UTC

(In reply to Pacho Ramos from comment #0)
> We are currently needing to manually set DOCS variable only to include this
> two files for many gnome packages because seems that they are fairly common
> then. 
> 
> I think would be really useful for us to also handle this two files to allow
> us to drop lots of DOCS="AUTHORS HACKING MAINTAINERS NEWS README" from
> ebuilds that are only needed to append this two files :)

no!  if maintainer has taken the time to define proper DOCS, it should never be removed!  package directory might have semi-empty files that shouldn't be installed and maintainer has defined DOCS="AUTHORS README" to skip everything else.  i'd be pretty pissed after seeing people dropping _defined variables with varying content_ from the ebuilds.

> 
> Thanks a lot

i'd prefer to see whole default list of files in DOCS be removed, so defining proper DOCS per ebuild would be mandatory.

Comment 2 Michał Górny archtester

2014-12-10 09:00:50 UTC

einstalldocs must not diverge from EAPI 6 spec, and the eutils impl will be disabled starting with EAPI 6.

Also nice that somebody bothered CC-ing the one who committed the function.

Comment 3 Pacho Ramos gentoo-dev

2014-12-11 10:01:51 UTC

(In reply to Michał Górny from comment #2)
[...]
> Also nice that somebody bothered CC-ing the one who committed the function.

As you weren't listed in the function as maintainer I thought it was now handled by base-system :| because other functions like validate_desktop_entries have their own maintained specified while this not :/. Sorry for that