| Summary: | app-editors/mg-20140414: suspicious use of einstall | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Current packages | Assignee: | Emacs project <emacs> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | suspicious-einstall | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 521420 | ||
This won't work here, because mg doesn't use autoconf, and the GNUmakefile is setting prefix=/usr/local. So we need to pass proper prefix and mandir, which is what the einstall shortcut just does. Since the install is trivial enough (it installs a single binary and its manpage), I've replaced einstall by dobin and doman. So it won't show up in your future scans. |
Please check whether the use of 'einstall' in this ebuild is actually needed. From a quick glance at the Makefile, it seems to have proper support for DESTDIR. Therefore, if possible please replace the call to 'einstall' with proper 'default' or 'emake DESTDIR="${D}" install'. Thanks.