Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 521422 - app-editors/mg-20140414: suspicious use of einstall
Summary: app-editors/mg-20140414: suspicious use of einstall
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Emacs project
URL:
Whiteboard: suspicious-einstall
Keywords:
Depends on:
Blocks: suspicious-einstall
  Show dependency tree
 
Reported: 2014-08-28 20:22 UTC by Michał Górny
Modified: 2014-08-29 20:27 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-08-28 20:22:22 UTC
Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.
Comment 1 Ulrich Müller gentoo-dev 2014-08-28 21:06:13 UTC
This won't work here, because mg doesn't use autoconf, and the GNUmakefile is setting prefix=/usr/local. So we need to pass proper prefix and mandir, which is what the einstall shortcut just does.
Comment 2 Ulrich Müller gentoo-dev 2014-08-29 06:29:28 UTC
Since the install is trivial enough (it installs a single binary and its manpage), I've replaced einstall by dobin and doman. So it won't show up in your future scans.