Summary: | =net-libs/rb_libtorrent-1.0.2 version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Anthony Ryan <anthonyryan1> |
Component: | [OLD] Library | Assignee: | Markos Chandras (RETIRED) <hwoarang> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | anthonyryan1, net-p2p |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
rb_libtorrent-1.0.1.ebuild.patch
rb_libtorrent-1.0.2.ebuild.patch rb_libtorrent-1.0.2.ebuild |
Description
Anthony Ryan
2014-08-20 01:44:40 UTC
Created attachment 383166 [details, diff]
rb_libtorrent-1.0.1.ebuild.patch
The patch looks good to me. Out of interest, have you done any compile testing on the reverse dependencies (eg qbittorrent) to determine the level of potential breakage? Might worth masking it for a while I haven't tested qbittorrent, but I have done extensive Deluge testing since I sent in this ebuild. For public tracker usage, the new version works incredibly well. But for private trackers there's a significant issue with the fact that "anonymous_mode" has been switched on by default. Approximately 10% of private trackers will not work with this version because of that. I have just finished working with the upstream to address this issue for 1.0.2. You can decide if we want to wait for the 1.0.2 release or I can backport the necessary patch. Let me know how you would like to proceed. Thank you for your efforts. If there is no huge demand to have 1.0.1 in portage, I'd rather wait for 1.0.2. Created attachment 384558 [details, diff]
rb_libtorrent-1.0.2.ebuild.patch
In addition to the previous patch, I have resolved a repoman warning about python 2.6 not being in the tree.
I attempted to migrate the ebuild to python-r1, but I was not confident in the result, so I have excluded those changes.
I will update this ticket if I find any further stability concerns.
I have actually already observed an issue in this. It seems after deploying this in a testing environment, a revdep-rebuild is necessary before the python bindings are usable. After updating from 0.16.17 to 1.0.2, revdep finds the following: broken /usr/lib64/python2.7/site-packages/libtorrent.so (requires libtorrent-rasterbar.so.7) A second rebuild of the package seems to resolve the issue, so it seems to me as though the /usr/lib64/python2.7/site-packages/libtorrent.so we're installing is compiled against the system libtorrent rather than the one in the sandbox. I will investigate this further as time allows. HOMEPAGE should be changed to either http://www.libtorrent.org/ or http://sourceforge.net/projects/libtorrent/ (or both) You're strongly suggested to switch to python-r1. If you're not confident with the changes required, have them reviewed by a member of the python team (e.g. mgorny) Please post your python-r1 version and then I will CC python@ to review your changes. Let me know when you think your 1.0.2 ebuild is good enough to I can review it. Created attachment 386348 [details]
rb_libtorrent-1.0.2.ebuild
I have attached the python-r1 version.
I have also removed the versionator inherit, as it's not used. It looks to me as though the multilib inherit isn't being used either, and this either needs to be updated to support multilib, or it should probably be removed.
I look forward to suggestions.
python/multilib: An ACK on the ebuild would be much appreciated. Thanks! Looks ok from the python side. ACK @ multilib, though there's not really much of our business here :P. Thank you all (dropping CCs). I will do some build testing before bumping it later today repoman gives me all sorts of weird problems which I don't have time to investigate yet. /home/hwoarang/development/gentoo-cvs/gentoo-x86/net-libs/rb_libtorrent/rb_libtorrent-1.0.2.ebuild: line 4: $'\r': command not found /home/hwoarang/development/gentoo-cvs/gentoo-x86/net-libs/rb_libtorrent/rb_libtorrent-1.0.2.ebuild: line 8: $'\r': command not found * ERROR: net-libs/rb_libtorrent-1.0.2::gentoo failed (depend phase): a dos2unix fixed it apparently. I will probably commit it masked because qbittorrent does not build with it. committed masked |