Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 520290 - =net-libs/rb_libtorrent-1.0.2 version bump
Summary: =net-libs/rb_libtorrent-1.0.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2014-08-20 01:44 UTC by Anthony Ryan
Modified: 2014-10-18 19:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rb_libtorrent-1.0.1.ebuild.patch (file_520290.txt,1.33 KB, patch)
2014-08-20 01:45 UTC, Anthony Ryan
Details | Diff
rb_libtorrent-1.0.2.ebuild.patch (file_520290.txt,1.40 KB, patch)
2014-09-11 05:00 UTC, Anthony Ryan
Details | Diff
rb_libtorrent-1.0.2.ebuild (file_520290.txt,2.03 KB, text/plain)
2014-10-10 04:54 UTC, Anthony Ryan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Ryan 2014-08-20 01:44:40 UTC
Version 1.0.1 was released last week.

I have taken the following actions to upgrade the ebuild:
1. EAPI -> 5
2. Remove RESTRICT="test" and added test to IUSE.
3. Set a new minimum boost version (this version of rb_libtorrent includes ed25519 code that requires this version, in the interest of not tampering with crypto code, I have simply required the newer version).
4. Tidied up various boost related assumptions now that there's a new minimum version.

Reproducible: Always
Comment 1 Anthony Ryan 2014-08-20 01:45:05 UTC
Created attachment 383166 [details, diff]
rb_libtorrent-1.0.1.ebuild.patch
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2014-08-27 17:42:57 UTC
The patch looks good to me. Out of interest, have you done any compile testing on the reverse dependencies (eg qbittorrent) to determine the level of potential breakage? Might worth masking it for a while
Comment 3 Anthony Ryan 2014-08-28 17:14:22 UTC
I haven't tested qbittorrent, but I have done extensive Deluge testing since I sent in this ebuild.

For public tracker usage, the new version works incredibly well. But for private trackers there's a significant issue with the fact that "anonymous_mode" has been switched on by default. Approximately 10% of private trackers will not work with this version because of that.

I have just finished working with the upstream to address this issue for 1.0.2. You can decide if we want to wait for the 1.0.2 release or I can backport the necessary patch.

Let me know how you would like to proceed.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2014-08-28 18:39:51 UTC
Thank you for your efforts. If there is no huge demand to have 1.0.1 in portage, I'd rather wait for 1.0.2.
Comment 5 Anthony Ryan 2014-09-11 05:00:14 UTC
Created attachment 384558 [details, diff]
rb_libtorrent-1.0.2.ebuild.patch

In addition to the previous patch, I have resolved a repoman warning about python 2.6 not being in the tree.

I attempted to migrate the ebuild to python-r1, but I was not confident in the result, so I have excluded those changes.

I will update this ticket if I find any further stability concerns.
Comment 6 Anthony Ryan 2014-09-11 05:21:43 UTC
I have actually already observed an issue in this. It seems after deploying this in a testing environment, a revdep-rebuild is necessary before the python bindings are usable.

After updating from 0.16.17 to 1.0.2, revdep finds the following:

    broken /usr/lib64/python2.7/site-packages/libtorrent.so (requires libtorrent-rasterbar.so.7)

A second rebuild of the package seems to resolve the issue, so it seems to me as though the /usr/lib64/python2.7/site-packages/libtorrent.so we're installing is compiled against the system libtorrent rather than the one in the sandbox.

I will investigate this further as time allows.
Comment 7 Davide Pesavento gentoo-dev 2014-09-13 16:07:16 UTC
HOMEPAGE should be changed to either http://www.libtorrent.org/ or http://sourceforge.net/projects/libtorrent/ (or both)

You're strongly suggested to switch to python-r1. If you're not confident with the changes required, have them reviewed by a member of the python team (e.g. mgorny)
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2014-10-02 20:31:49 UTC
Please post your python-r1 version and then I will CC python@ to review your changes. Let me know when you think your 1.0.2 ebuild is good enough to I can review it.
Comment 9 Anthony Ryan 2014-10-10 04:54:44 UTC
Created attachment 386348 [details]
rb_libtorrent-1.0.2.ebuild

I have attached the python-r1 version.

I have also removed the versionator inherit, as it's not used. It looks to me as though the multilib inherit isn't being used either, and this either needs to be updated to support multilib, or it should probably be removed.

I look forward to suggestions.
Comment 10 Markos Chandras (RETIRED) gentoo-dev 2014-10-17 21:56:04 UTC
python/multilib: An ACK on the ebuild would be much appreciated. Thanks!
Comment 11 Mike Gilbert gentoo-dev 2014-10-17 22:29:47 UTC
Looks ok from the python side.
Comment 12 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-10-18 04:02:32 UTC
ACK @ multilib, though there's not really much of our business here :P.
Comment 13 Markos Chandras (RETIRED) gentoo-dev 2014-10-18 09:24:52 UTC
Thank you all (dropping CCs). I will do some build testing before bumping it later today
Comment 14 Markos Chandras (RETIRED) gentoo-dev 2014-10-18 17:11:10 UTC
repoman gives me all sorts of weird problems which I don't have time to investigate yet.

/home/hwoarang/development/gentoo-cvs/gentoo-x86/net-libs/rb_libtorrent/rb_libtorrent-1.0.2.ebuild: line 4: $'\r': command not found
/home/hwoarang/development/gentoo-cvs/gentoo-x86/net-libs/rb_libtorrent/rb_libtorrent-1.0.2.ebuild: line 8: $'\r': command not found
 * ERROR: net-libs/rb_libtorrent-1.0.2::gentoo failed (depend phase):
Comment 15 Markos Chandras (RETIRED) gentoo-dev 2014-10-18 18:22:09 UTC
a dos2unix fixed it apparently.
Comment 16 Markos Chandras (RETIRED) gentoo-dev 2014-10-18 19:24:50 UTC
I will probably commit it masked because qbittorrent does not build with it.
Comment 17 Markos Chandras (RETIRED) gentoo-dev 2014-10-18 19:35:47 UTC
committed masked