Summary: | sys-apps/util-linux: please review prefix changes | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christoph Junghans (RETIRED) <junghans> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dirk.heinrichs, prefix |
Priority: | Normal | Keywords: | Inclusion, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=515472 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 315803 | ||
Attachments: | patch against gx86 version |
Description
Christoph Junghans (RETIRED)
2014-08-03 01:34:20 UTC
enable-fs-paths-extra is fine i'm not groking why libdir is needed ... isn't this the same as the default ? (In reply to SpanKY from comment #1) > enable-fs-paths-extra is fine > > i'm not groking why libdir is needed ... isn't this the same as the default ? util-linux configure's contains: AS_CASE([$libdir], ['${exec_prefix}/'* | '${prefix}/'* | /usr/*], [usrlib_execdir=$libdir], [usrlib_execdir='${exec_prefix}'$libdir] ) AC_SUBST([usrlib_execdir]) It basically means that $libdir is consider as a sub-directory if is don't match '${exec_prefix}/'* | '${prefix}/'* | /usr/*. So for normal installs (prefix=/usr/*) everything is fine, but for prefix one ends up with a double prefix. prefix=${EPREFIX}/usr && libdir= ${EPREFIX}/lib-> libdir=${EPREFIX}/usr/$libidr = ${EPREFIX}/usr/${EPREFIX}/lib libdir='${prefix}/'"$(get_libdir)" works around that issue. libdir=$(get_libdir) would work, too. ok, should add a comment above the econf else it might get cleaned up # We manually set --libdir to the default since on prefix, econf will set it to # a value which the configure script does not recognize. This makes it set the # usrlib_execdir to a bad value. + 05 Aug 2014; Christoph Junghans <ottxor@gentoo.org> util-linux-2.24.2.ebuild: + added prefix support (bug #518898) + BTW <https://github.com/karelzak/util-linux/pull/109> got merged, so we can drop the --libdir hack for >2.25 (noted in the comment!) *** Bug 489730 has been marked as a duplicate of this bug. *** |