Summary: | packages inheriting autotools-utils.eclass but using myconfargs instead of myeconfargs | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Casper Ti. Vector <CasperVector> |
Component: | [OLD] Unspecified | Assignee: | Maciej Mrozowski <reavertm> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | CasperVector, jer, mgorny |
Priority: | Normal | Keywords: | Tracker |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 519286, 519288, 519292, 519294, 519296 | ||
Bug Blocks: |
Description
Casper Ti. Vector
2014-07-25 15:22:25 UTC
(In reply to Casper Ti. Vector from comment #0) > As the title implies, `myconfargs' is not a valid eclass API, and should be > replaced by `myeconfargs'. What is an eclass EAPI? > # find /usr/portage -name '*.ebuild' -exec sed -i > 's/myconfargs/myeconfargs/g' '{}' ';' If it is that trivial then what is the point? To put it clearly, `myconfargs' is a typo [1], and should be replaced by `myeconfargs', which is used by eclasses to provide extra arguments to wrapped `econf' (for example, those in `autotools-utils_src_configure'): % grep -r 'myconfargs' /usr/portage/eclass % grep -r 'myeconfargs' /usr/portage/eclass /usr/portage/eclass/ChangeLog-2013: Deprecate systemd_to_myeconfargs(). It's redundant and unnecessarily /usr/portage/eclass/xorg-2.eclass: local myeconfargs=( /usr/portage/eclass/systemd.eclass:# local myeconfargs=( /usr/portage/eclass/systemd.eclass:# econf "${myeconfargs[@]}" /usr/portage/eclass/systemd.eclass:# to preserve whitespace in paths. systemd_to_myeconfargs() is preferred over /usr/portage/eclass/systemd.eclass:# @FUNCTION: systemd_to_myeconfargs /usr/portage/eclass/systemd.eclass:# scripts to the myeconfargs variable used by autotools-utils eclass. Handles /usr/portage/eclass/systemd.eclass:systemd_to_myeconfargs() { /usr/portage/eclass/systemd.eclass: eqawarn 'systemd_to_myeconfargs() is deprecated and will be removed on 2013-10-11.' /usr/portage/eclass/systemd.eclass: myeconfargs=( /usr/portage/eclass/systemd.eclass: "${myeconfargs[@]}" /usr/portage/eclass/autotools-utils.eclass:# local myeconfargs=( /usr/portage/eclass/autotools-utils.eclass:# in myeconfargs are passed here to econf. Additionally following USE /usr/portage/eclass/autotools-utils.eclass:# @VARIABLE: myeconfargs /usr/portage/eclass/autotools-utils.eclass:# local myeconfargs=( /usr/portage/eclass/autotools-utils.eclass: [[ -z ${myeconfargs+1} || $(declare -p myeconfargs) == 'declare -a'* ]] \ /usr/portage/eclass/autotools-utils.eclass: || die 'autotools-utils.eclass: myeconfargs has to be an array.' /usr/portage/eclass/autotools-utils.eclass: econfargs+=("${myeconfargs[@]}") [1] Among the ebuilds found using `myconfargs', no one seems to use it side by side with `myeconfargs' deliberately, which indicate they are exactly typos. After consulting devs on #gentoo at freenode, this has been reported separately (one per package) as #519286, #519288, #519292, #519294 and #519296, though I personally doubt whether this is more efficient than reporting as one bug. Plus, reverting status to `UNCONFIRMED' after consulting the same people on IRC. Hmm, lolfail. Let's find the pattern. Ok, I don't see any specific pattern. It seems that different people are making this typo. Yet another reason to kill autotools-utils. All occurrences fixed now. Thanks for the report! |