| Summary: | fortune offensive broken | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Olivier Crete (RETIRED) <tester> |
| Component: | Current packages | Assignee: | José Alberto Suárez López <bass> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | sindian |
| Priority: | High | ||
| Version: | 1.3 | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | patched ebuild | ||
|
Description
Olivier Crete (RETIRED)
2002-07-17 16:29:36 UTC
I have a fix. $offensive wasn't being checked in the ebuild. The Makefile that comes with the tarball sets the offensive parameter to 1 by default; the sed expression in the ebuild changes this Makefile parameter to unset even if $offensive is 1. There are now two cases in the ebuild: offensive or not offensive. In the offensive case, I removed the sed subexpression that unsets the offensive Makefile parameter. In the not offensive case, I used the same sed expression. Side note: I made $offensive global, so that it could be used in src_compile and src_install. I have tested this on x86 gentoo 1.2 for three cases: $offensive=1, $offensive=0, and $offensive= ($offensive unset). I guess it still needs to be tested on PPC, though it should work there as well. I realize this description may not be so clear. The code should be... Let me know if this works out. It's my first gentoo fix, and I could use the feedback. Created attachment 2351 [details]
patched ebuild
This is the patched ebuild I described earlier.
|