Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 5179 - fortune offensive broken
Summary: fortune offensive broken
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High major (vote)
Assignee: José Alberto Suárez López
Depends on:
Reported: 2002-07-17 16:29 UTC by Olivier Crete (RETIRED)
Modified: 2003-02-04 19:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

patched ebuild (fortune-mod-9708.ebuild,2.62 KB, text/plain)
2002-07-18 01:19 UTC, Arun Thomas (RETIRED)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Crete (RETIRED) gentoo-dev 2002-07-17 16:29:36 UTC
I tried emerging fortune and setting offensive to 1 in the ebuild and it still
doesnt install the "offensive" stuff...
Comment 1 Arun Thomas (RETIRED) gentoo-dev 2002-07-18 01:17:54 UTC
I have a fix. $offensive wasn't being checked in the ebuild. The Makefile that
comes with the tarball sets the offensive parameter to 1 by default; the sed
expression in the ebuild changes this Makefile parameter to unset even if
$offensive is 1. 

There are now two cases in the ebuild: offensive or not offensive. In the
offensive case, I removed the sed subexpression that unsets the offensive
Makefile parameter. In the not offensive case, I used the same sed expression.
Side note: I made $offensive global, so that it could be used in src_compile and

I have tested this on x86 gentoo 1.2 for three cases: $offensive=1,
$offensive=0, and $offensive= ($offensive unset). I guess it still needs to be
tested on PPC, though it should work there as well.

I realize this description may not be so clear. The code should be... Let me
know if this works out. It's my first gentoo fix, and I could use the feedback.
Comment 2 Arun Thomas (RETIRED) gentoo-dev 2002-07-18 01:19:08 UTC
Created attachment 2351 [details]
patched ebuild

This is the patched ebuild I described earlier.