Summary: | x11-libs/libqxt - QxtGlobalShortcut should support multimedia keys frequently found on keyboards. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Georg Rudoy <0xd34df00d> |
Component: | [OLD] Library | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | esigra, fatzer2, nikoli |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 326673 | ||
Attachments: | Patch fixing the issue |
Description
Georg Rudoy
2013-12-25 11:53:55 UTC
Created attachment 366172 [details, diff] Patch fixing the issue The patch is taken from Fedora at http://pkgs.fedoraproject.org/cgit/libqxt.git/tree/libqxt-media-keys.patch . This is also the same patch applied to lc-gacts bundled version of Qxt. Seems to work for me. Patch added in -r2 The patch is not same as in https://github.com/clementine-player/Clementine/blob/master/3rdparty/qxt/media-keys.patch , why part of it was removed? Hard to say, I've just borrowed the patch from Fedora. Looks like the difference should be put back to Gentoo's patch. Thanks for noticing this. Please also consider adding this patch: https://github.com/clementine-player/Clementine/blob/master/3rdparty/qxt/meta-modifier.patch Then it will be possible to use in clementine ebuilds system qxt copy instead of bundled. (In reply to Nikoli from comment #5) > Please also consider adding this patch: > https://github.com/clementine-player/Clementine/blob/master/3rdparty/qxt/ > meta-modifier.patch > Is that an upstream patch? Seems author of patch is David Sansome, main Clementine dev: https://github.com/clementine-player/Clementine/commit/35f0c65046c6e25d3749f6a2be8648b73c64e33a https://github.com/clementine-player/Clementine/issues/329 Do not know if libqxt devs accepted and applied the patch. libqxt upstream is dead and there's only a couple of Qt 4 revdeps still using this package. Once they're cleaned up, this package will be last rited. |